Skip to content

Commit 7364d23

Browse files
committed
Strip objectId out of responses from HooksController
1 parent dd1d18d commit 7364d23

File tree

1 file changed

+21
-10
lines changed

1 file changed

+21
-10
lines changed

src/Routers/HooksRouter.js

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ export class HooksRouter extends PromiseRouter {
2323
if (!foundFunction) {
2424
throw new Parse.Error(143, `no function named: ${req.params.functionName} is defined`);
2525
}
26-
return Promise.resolve({response: foundFunction});
26+
return Promise.resolve({response: stripObjectId(foundFunction)});
2727
});
2828
}
29-
29+
3030
return hooksController.getFunctions().then((functions) => {
31-
return { response: functions || [] };
31+
return { response: stripObjectIds(functions) || [] };
3232
}, (err) => {
3333
throw err;
3434
});
@@ -37,16 +37,27 @@ export class HooksRouter extends PromiseRouter {
3737
handleGetTriggers(req) {
3838
var hooksController = req.config.hooksController;
3939
if (req.params.className && req.params.triggerName) {
40-
40+
4141
return hooksController.getTrigger(req.params.className, req.params.triggerName).then((foundTrigger) => {
4242
if (!foundTrigger) {
4343
throw new Parse.Error(143,`class ${req.params.className} does not exist`);
4444
}
45-
return Promise.resolve({response: foundTrigger});
45+
return Promise.resolve({response: HooksRouter.stripObjectId(foundTrigger)});
4646
});
4747
}
48-
49-
return hooksController.getTriggers().then((triggers) => ({ response: triggers || [] }));
48+
49+
return hooksController.getTriggers().then((triggers) => {
50+
return { response: HooksRouter.stripObjectIds(triggers) || [] });
51+
});
52+
}
53+
54+
static stripObjectId(result) {
55+
delete result.objectId;
56+
return result;
57+
}
58+
59+
static stripObjectIds(results) {
60+
return results.map(result => HooksRouter.stripObjectId);
5061
}
5162

5263
handleDelete(req) {
@@ -73,10 +84,10 @@ export class HooksRouter extends PromiseRouter {
7384
hook.url = req.body.url
7485
} else {
7586
throw new Parse.Error(143, "invalid hook declaration");
76-
}
87+
}
7788
return this.updateHook(hook, req.config);
7889
}
79-
90+
8091
handlePut(req) {
8192
var body = req.body;
8293
if (body.__op == "Delete") {
@@ -85,7 +96,7 @@ export class HooksRouter extends PromiseRouter {
8596
return this.handleUpdate(req);
8697
}
8798
}
88-
99+
89100
mountRoutes() {
90101
this.route('GET', '/hooks/functions', middleware.promiseEnforceMasterKeyAccess, this.handleGetFunctions.bind(this));
91102
this.route('GET', '/hooks/triggers', middleware.promiseEnforceMasterKeyAccess, this.handleGetTriggers.bind(this));

0 commit comments

Comments
 (0)