refactoring database code (#4448)

* refactoring database code

Starting to refactor the database code for better use of promises + ES6 generators, to prepare for ES7 await/async.

* Update PostgresStorageAdapter.js

* Update PostgresStorageAdapter.js

naming the transaction.

Author: vitaly-t

src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

@@ -843,35 +843,26 @@ export class PostgresStorageAdapter implements StorageAdapter {
   // Returns a Promise.
   deleteFields(className: string, schema: SchemaType, fieldNames: string[]): Promise<void> {
     debug('deleteFields', className, fieldNames);
-    return Promise.resolve()
-      .then(() => {
-        fieldNames = fieldNames.reduce((list: string[], fieldName: string) => {
-          const field = schema.fields[fieldName]
-          if (field.type !== 'Relation') {
-            list.push(fieldName);
-          }
-          delete schema.fields[fieldName];
-          return list;
-        }, []);
-
-        const values = [className, ...fieldNames];
-        const columns = fieldNames.map((name, idx) => {
-          return `$${idx + 2}:name`;
-        }).join(', DROP COLUMN');
-
-        const doBatch = (t) => {
-          const batch = [
-            t.none('UPDATE "_SCHEMA" SET "schema"=$<schema> WHERE "className"=$<className>', {schema, className})
-          ];
-          if (values.length > 1) {
-            batch.push(t.none(`ALTER TABLE $1:name DROP COLUMN ${columns}`, values));
-          }
-          return batch;
-        }
-        return this._client.tx((t) => {
-          return t.batch(doBatch(t));
-        });
-      });
+    fieldNames = fieldNames.reduce((list, fieldName) => {
+      const field = schema.fields[fieldName]
+      if (field.type !== 'Relation') {
+        list.push(fieldName);
+      }
+      delete schema.fields[fieldName];
+      return list;
+    }, []);
+
+    const values = [className, ...fieldNames];
+    const columns = fieldNames.map((name, idx) => {
+      return `$${idx + 2}:name`;
+    }).join(', DROP COLUMN');
+
+    return this._client.tx('delete-fields', function * (t) {
+      yield t.none('UPDATE "_SCHEMA" SET "schema"=$<schema> WHERE "className"=$<className>', {schema, className});
+      if (values.length > 1) {
+        yield t.none(`ALTER TABLE $1:name DROP COLUMN ${columns}`, values);
+      }
+    });
   }
 
   // Return a promise for all schemas known to this adapter, in Parse format. In case the