Skip to content

Commit b47c927

Browse files
committed
Changed FileLoggerAdapterSpec to fail gracefully on Windows
Running tests on Windows caused this error: ``` B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:38 expect(results[0].message).toEqual('testing info logs'); ^ TypeError: Cannot read property 'message' of undefined at B:\Projects\Parse Server\parse-server\spec\FileLoggerAdapter.spec.js:38:26 at ParsePromise.<anonymous> (B:\Projects\Parse Server\parse-server\src\Adapters\Logger\FileLoggerAdapter.js:9:17440) at ParsePromise.wrappedResolvedCallback (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:139:41) at ParsePromise.resolve (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:72:36) at resolveOne (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:471:29) at ParsePromise.object.then.errors.(anonymous function) (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:480:13) at ParsePromise.wrappedResolvedCallback (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:139:41) at ParsePromise.resolve (B:\Projects\Parse Server\parse-server\node_modules\parse\lib\node\ParsePromise.js:72:36) at ReadFileContext.callback (B:\Projects\Parse Server\parse-server\src\Adapters\Logger\FileLoggerAdapter.js:9:16189) at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:303:13) ``` Rest of the tests could not be run as the test runner would break here. This change adds a check to fail when the FileLoggerAdapter returns an empty array from here: https://github.com/ParsePlatform/parse-server/blob/master/src/Adapters/Logger/FileLoggerAdapter.js#L191 Regarding the cause of the error itself, it is due to different filename separators in *nix and Windows. The FileLoggerAdapter would not save logs (have not tested this). This is a separate issue and should also be fixed.
1 parent f08b0b3 commit b47c927

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

spec/FileLoggerAdapter.spec.js

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,13 @@ describe('info logs', () => {
3535
size: 1,
3636
level: 'info'
3737
}, (results) => {
38-
expect(results[0].message).toEqual('testing info logs');
39-
done();
38+
if(results.length == 0) {
39+
fail('The adapter should return non-empty results');
40+
done();
41+
} else {
42+
expect(results[0].message).toEqual('testing info logs');
43+
done();
44+
}
4045
});
4146
});
4247
});
@@ -56,8 +61,14 @@ describe('error logs', () => {
5661
size: 1,
5762
level: 'error'
5863
}, (results) => {
59-
expect(results[0].message).toEqual('testing error logs');
60-
done();
64+
if(results.length == 0) {
65+
fail('The adapter should return non-empty results');
66+
done();
67+
}
68+
else {
69+
expect(results[0].message).toEqual('testing error logs');
70+
done();
71+
}
6172
});
6273
});
6374
});

0 commit comments

Comments
 (0)