LiveQuery spec remove duplicates and listeners

Author: dplewis

spec/CloudCodeLogger.spec.js

@@ -14,6 +14,7 @@ describe('Cloud Code Logger', () => {
     return reconfigureServer({
       // useful to flip to false for fine tuning :).
       silent: true,
+      logLevel: undefined,
     })
       .then(() => {
         return Parse.User.signUp('tester', 'abc')

spec/ParseLiveQuery.spec.js

@@ -15,12 +15,14 @@ describe('ParseLiveQuery', function () {
       verbose: false,
       silent: true,
     });
+    Parse.CoreManager.getLiveQueryController().setDefaultLiveQueryClient(null);
     const requestedUser = new Parse.User();
     requestedUser.setUsername('username');
     requestedUser.setPassword('password');
     Parse.Cloud.onLiveQueryEvent(req => {
       const { event, sessionToken } = req;
       if (event === 'ws_disconnect') {
+        Parse.Cloud._removeAllHooks();
         expect(sessionToken).toBeDefined();
         expect(sessionToken).toBe(requestedUser.getSessionToken());
         done();
@@ -356,185 +358,6 @@ describe('ParseLiveQuery', function () {
     await object.save();
   });
 
-  it('expect afterEvent create', async done => {
-    await reconfigureServer({
-      liveQuery: {
-        classNames: ['TestObject'],
-      },
-      startLiveQueryServer: true,
-      verbose: false,
-      silent: true,
-    });
-    Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
-      expect(req.event).toBe('create');
-      expect(req.user).toBeUndefined();
-      expect(req.object.get('foo')).toBe('bar');
-    });
-
-    const query = new Parse.Query(TestObject);
-    const subscription = await query.subscribe();
-    subscription.on('create', object => {
-      expect(object.get('foo')).toBe('bar');
-      done();
-    });
-
-    const object = new TestObject();
-    object.set('foo', 'bar');
-    await object.save();
-  });
-
-  it('expect afterEvent payload', async done => {
-    await reconfigureServer({
-      liveQuery: {
-        classNames: ['TestObject'],
-      },
-      startLiveQueryServer: true,
-      verbose: false,
-      silent: true,
-    });
-    const object = new TestObject();
-    await object.save();
-
-    Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
-      expect(req.event).toBe('update');
-      expect(req.user).toBeUndefined();
-      expect(req.object.get('foo')).toBe('bar');
-      expect(req.original.get('foo')).toBeUndefined();
-      done();
-    });
-
-    const query = new Parse.Query(TestObject);
-    query.equalTo('objectId', object.id);
-    await query.subscribe();
-    object.set({ foo: 'bar' });
-    await object.save();
-  });
-
-  it('expect afterEvent enter', async done => {
-    await reconfigureServer({
-      liveQuery: {
-        classNames: ['TestObject'],
-      },
-      startLiveQueryServer: true,
-      verbose: false,
-      silent: true,
-    });
-    Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
-      expect(req.event).toBe('enter');
-      expect(req.user).toBeUndefined();
-      expect(req.object.get('foo')).toBe('bar');
-      expect(req.original.get('foo')).toBeUndefined();
-    });
-
-    const object = new TestObject();
-    await object.save();
-
-    const query = new Parse.Query(TestObject);
-    query.equalTo('foo', 'bar');
-    const subscription = await query.subscribe();
-    subscription.on('enter', object => {
-      expect(object.get('foo')).toBe('bar');
-      done();
-    });
-
-    object.set('foo', 'bar');
-    await object.save();
-  });
-
-  it('expect afterEvent leave', async done => {
-    await reconfigureServer({
-      liveQuery: {
-        classNames: ['TestObject'],
-      },
-      startLiveQueryServer: true,
-      verbose: false,
-      silent: true,
-    });
-    Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
-      expect(req.event).toBe('leave');
-      expect(req.user).toBeUndefined();
-      expect(req.object.get('foo')).toBeUndefined();
-      expect(req.original.get('foo')).toBe('bar');
-    });
-
-    const object = new TestObject();
-    object.set('foo', 'bar');
-    await object.save();
-
-    const query = new Parse.Query(TestObject);
-    query.equalTo('foo', 'bar');
-    const subscription = await query.subscribe();
-    subscription.on('leave', object => {
-      expect(object.get('foo')).toBeUndefined();
-      done();
-    });
-
-    object.unset('foo');
-    await object.save();
-  });
-
-  it('expect afterEvent delete', async done => {
-    await reconfigureServer({
-      liveQuery: {
-        classNames: ['TestObject'],
-      },
-      startLiveQueryServer: true,
-      verbose: false,
-      silent: true,
-    });
-    Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
-      expect(req.event).toBe('delete');
-      expect(req.user).toBeUndefined();
-      req.object.set('foo', 'bar');
-    });
-
-    const object = new TestObject();
-    await object.save();
-
-    const query = new Parse.Query(TestObject);
-    query.equalTo('objectId', object.id);
-
-    const subscription = await query.subscribe();
-    subscription.on('delete', object => {
-      expect(object.get('foo')).toBe('bar');
-      done();
-    });
-
-    await object.destroy();
-  });
-
-  it('can handle afterEvent modification', async done => {
-    await reconfigureServer({
-      liveQuery: {
-        classNames: ['TestObject'],
-      },
-      startLiveQueryServer: true,
-      verbose: false,
-      silent: true,
-    });
-    const object = new TestObject();
-    await object.save();
-
-    Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
-      const current = req.object;
-      current.set('foo', 'yolo');
-
-      const original = req.original;
-      original.set('yolo', 'foo');
-    });
-
-    const query = new Parse.Query(TestObject);
-    query.equalTo('objectId', object.id);
-    const subscription = await query.subscribe();
-    subscription.on('update', (object, original) => {
-      expect(object.get('foo')).toBe('yolo');
-      expect(original.get('yolo')).toBe('foo');
-      done();
-    });
-    object.set({ foo: 'bar' });
-    await object.save();
-  });
-
   it('can handle async afterEvent modification', async done => {
     await reconfigureServer({
       liveQuery: {
@@ -622,6 +445,7 @@ describe('ParseLiveQuery', function () {
     Parse.Cloud.beforeConnect(() => {}, validatorFail);
     let complete = false;
     Parse.LiveQuery.on('error', error => {
+      Parse.LiveQuery.removeAllListeners('error');
       if (complete) {
         return;
       }
@@ -695,6 +519,7 @@ describe('ParseLiveQuery', function () {
       throw new Error('You shall not pass!');
     });
     Parse.LiveQuery.on('error', error => {
+      Parse.LiveQuery.removeAllListeners('error');
       expect(error).toBe('You shall not pass!');
       done();
     });
@@ -725,6 +550,7 @@ describe('ParseLiveQuery', function () {
     query.equalTo('objectId', object.id);
     const subscription = await query.subscribe();
     subscription.on('error', error => {
+      Parse.LiveQuery.removeAllListeners('error');
       expect(error).toBe('You shall not subscribe!');
       done();
     });

spec/ParseQuery.Aggregate.spec.js

@@ -1404,20 +1404,16 @@ describe('Parse.Query Aggregate testing', () => {
     expect(results.length).toEqual(2);
     expect(results[0].value).toEqual(2);
     expect(results[1].value).toEqual(3);
+    await database.adapter.deleteAllClasses(false);
   });
 
   it_only_db('mongo')('aggregate geoNear with near GeoJSON point', async () => {
     // Create geo index which is required for `geoNear` query
     const database = Config.get(Parse.applicationId).database;
     const schema = await new Parse.Schema('GeoObject').save();
-    await database.adapter.ensureIndex(
-      'GeoObject',
-      schema,
-      ['location'],
-      undefined,
-      false,
-      '2dsphere'
-    );
+    await database.adapter.ensureIndex('GeoObject', schema, ['location'], undefined, false, {
+      indexType: '2dsphere',
+    });
     // Create objects
     const GeoObject = Parse.Object.extend('GeoObject');
     const obj1 = new GeoObject({
@@ -1454,20 +1450,16 @@ describe('Parse.Query Aggregate testing', () => {
     const results = await query.aggregate(pipeline);
     // Check results
     expect(results.length).toEqual(3);
+    await database.adapter.deleteAllClasses(false);
   });
 
   it_only_db('mongo')('aggregate geoNear with near legacy coordinate pair', async () => {
     // Create geo index which is required for `geoNear` query
     const database = Config.get(Parse.applicationId).database;
     const schema = await new Parse.Schema('GeoObject').save();
-    await database.adapter.ensureIndex(
-      'GeoObject',
-      schema,
-      ['location'],
-      undefined,
-      false,
-      '2dsphere'
-    );
+    await database.adapter.ensureIndex('GeoObject', schema, ['location'], undefined, false, {
+      indexType: '2dsphere',
+    });
     // Create objects
     const GeoObject = Parse.Object.extend('GeoObject');
     const obj1 = new GeoObject({
@@ -1501,5 +1493,6 @@ describe('Parse.Query Aggregate testing', () => {
     const results = await query.aggregate(pipeline);
     // Check results
     expect(results.length).toEqual(3);
+    await database.adapter.deleteAllClasses(false);
   });
 });

spec/helper.js

@@ -1,9 +1,10 @@
 'use strict';
 const semver = require('semver');
+const CurrentSpecReporter = require('./support/CurrentSpecReporter.js');
 
 // Sets up a Parse API server for testing.
-jasmine.DEFAULT_TIMEOUT_INTERVAL = process.env.PARSE_SERVER_TEST_TIMEOUT || 5000;
-
+jasmine.DEFAULT_TIMEOUT_INTERVAL = process.env.PARSE_SERVER_TEST_TIMEOUT || 10000;
+jasmine.getEnv().addReporter(new CurrentSpecReporter());
 if (process.env.PARSE_SERVER_LOG_LEVEL === 'debug') {
   const { SpecReporter } = require('jasmine-spec-reporter');
   jasmine.getEnv().addReporter(new SpecReporter());

spec/schemas.spec.js

@@ -141,8 +141,8 @@ const masterKeyHeaders = {
 
 describe('schemas', () => {
   beforeEach(async () => {
-    config = Config.get('test');
     await reconfigureServer();
+    config = Config.get('test');
   });
 
   afterEach(async () => {

spec/support/CurrentSpecReporter.js

@@ -0,0 +1,15 @@
+// Sets a global variable to the current test spec
+// ex: global.currentSpec.description
+
+global.currentSpec = null;
+
+class CurrentSpecReporter {
+  specStarted(spec) {
+    global.currentSpec = spec;
+  }
+  specDone() {
+    global.currentSpec = null;
+  }
+}
+
+module.exports = CurrentSpecReporter;