ReflectionExtension: union type support (#39)

Author: pepakriz

src/Extension/ReflectionExtension.php

@@ -10,9 +10,11 @@
 use PHPStan\Broker\Broker;
 use PHPStan\Broker\ClassNotFoundException;
 use PHPStan\Reflection\MethodReflection;
-use PHPStan\Type\Constant\ConstantStringType;
+use PHPStan\Type\NeverType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\TypeUtils;
 use PHPStan\Type\VoidType;
 use ReflectionClass;
 use ReflectionException;
@@ -65,12 +67,21 @@ public function getThrowTypeFromConstructor(MethodReflection $methodReflection,
 	private function resolveReflectionClass(New_ $newNode, Scope $scope): Type
 	{
 		$reflectionExceptionType = new ObjectType(ReflectionException::class);
-		$valueType = $scope->getType($newNode->args[0]->value);
-		if (!$valueType instanceof ConstantStringType) {
+		if (!isset($newNode->args[0])) {
 			return $reflectionExceptionType;
 		}
 
-		if (!$this->broker->hasClass($valueType->getValue())) {
+		$valueType = $scope->getType($newNode->args[0]->value);
+
+		foreach (TypeUtils::getConstantStrings($valueType) as $constantString) {
+			if (!$this->broker->hasClass($constantString->getValue())) {
+				return $reflectionExceptionType;
+			}
+
+			$valueType = TypeCombinator::remove($valueType, $constantString);
+		}
+
+		if (!$valueType instanceof NeverType) {
 			return $reflectionExceptionType;
 		}
 
@@ -80,12 +91,20 @@ private function resolveReflectionClass(New_ $newNode, Scope $scope): Type
 	private function resolveReflectionFunction(New_ $newNode, Scope $scope): Type
 	{
 		$reflectionExceptionType = new ObjectType(ReflectionException::class);
-		$valueType = $scope->getType($newNode->args[0]->value);
-		if (!$valueType instanceof ConstantStringType) {
+		if (!isset($newNode->args[0])) {
 			return $reflectionExceptionType;
 		}
 
-		if (!$this->broker->hasFunction(new Name($valueType->getValue()), $scope)) {
+		$valueType = $scope->getType($newNode->args[0]->value);
+		foreach (TypeUtils::getConstantStrings($valueType) as $constantString) {
+			if (!$this->broker->hasFunction(new Name($constantString->getValue()), $scope)) {
+				return $reflectionExceptionType;
+			}
+
+			$valueType = TypeCombinator::remove($valueType, $constantString);
+		}
+
+		if (!$valueType instanceof NeverType) {
 			return $reflectionExceptionType;
 		}
 
@@ -95,21 +114,39 @@ private function resolveReflectionFunction(New_ $newNode, Scope $scope): Type
 	private function resolveReflectionProperty(New_ $newNode, Scope $scope): Type
 	{
 		$reflectionExceptionType = new ObjectType(ReflectionException::class);
-		$valueType = $scope->getType($newNode->args[0]->value);
-		if (!$valueType instanceof ConstantStringType) {
+		if (!isset($newNode->args[1])) {
 			return $reflectionExceptionType;
 		}
 
+		$valueType = $scope->getType($newNode->args[0]->value);
 		$propertyType = $scope->getType($newNode->args[1]->value);
-		if (!$propertyType instanceof ConstantStringType) {
+		foreach (TypeUtils::getConstantStrings($valueType) as $constantString) {
+			if (!$this->broker->hasClass($constantString->getValue())) {
+				return $reflectionExceptionType;
+			}
+
+			foreach (TypeUtils::getConstantStrings($propertyType) as $constantPropertyString) {
+				try {
+					if (!$this->broker->getClass($constantString->getValue())->hasProperty($constantPropertyString->getValue())) {
+						return $reflectionExceptionType;
+					}
+				} catch (ClassNotFoundException $e) {
+					return $reflectionExceptionType;
+				}
+			}
+
+			$valueType = TypeCombinator::remove($valueType, $constantString);
+		}
+
+		foreach (TypeUtils::getConstantStrings($propertyType) as $constantPropertyString) {
+			$propertyType = TypeCombinator::remove($propertyType, $constantPropertyString);
+		}
+
+		if (!$valueType instanceof NeverType) {
 			return $reflectionExceptionType;
 		}
 
-		try {
-			if (!$this->broker->getClass($valueType->getValue())->hasProperty($propertyType->getValue())) {
-				return $reflectionExceptionType;
-			}
-		} catch (ClassNotFoundException $e) {
+		if (!$propertyType instanceof NeverType) {
 			return $reflectionExceptionType;
 		}
 

tests/src/Rules/data/throws-php-internal-functions.php

@@ -4,17 +4,29 @@
 
 use DateTime;
 use DateTimeImmutable;
-use function rand;
 use ReflectionClass;
 use ReflectionFunction;
 use ReflectionProperty;
 use ReflectionZendExtension;
+use Throwable;
+use function rand;
+
+class ValueObject
+{
+
+	private $property;
+
+	private $secondProperty;
+
+}
 
 class Example
 {
 
 	private $property;
 
+	private $secondProperty;
+
 	public function testReflection(): void
 	{
 		new ReflectionClass(self::class);
@@ -29,6 +41,17 @@ public function testReflection(): void
 		new ReflectionFunction('undefinedFunction'); // error: Missing @throws ReflectionException annotation
 
 		new ReflectionZendExtension('unknownZendExtension'); // error: Missing @throws ReflectionException annotation
+
+		new ReflectionClass(rand(0, 1) === 0 ? self::class : Throwable::class);
+		new ReflectionClass(rand(0, 1) === 0 ? self::class : null); // error: Missing @throws ReflectionException annotation
+		new ReflectionClass(rand(0, 1) === 0 ? self::class : 'undefinedClass'); // error: Missing @throws ReflectionException annotation
+
+		new ReflectionProperty(rand(0, 1) === 0 ? self::class : ValueObject::class, rand(0, 1) === 0 ? 'property' : 'secondProperty');
+		new ReflectionProperty(rand(0, 1) === 0 ? self::class : null, rand(0, 1) === 0 ? 'property' : 'secondProperty'); // error: Missing @throws ReflectionException annotation
+		new ReflectionProperty(rand(0, 1) === 0 ? self::class : Throwable::class, rand(0, 1) === 0 ? 'property' : 'undefinedProperty'); // error: Missing @throws ReflectionException annotation
+
+		new ReflectionFunction(rand(0, 1) === 0 ? 'count' : 'sort');
+		new ReflectionFunction(rand(0, 1) === 0 ? 'count' : 'undefinedFunction'); // error: Missing @throws ReflectionException annotation
 	}
 
 	public function testDateTime(): void