Fix PHP-8.4-dev typedef redefinition warnings

This fixes warnings that fill up the build log due to different
compilation flags used and clang.

See: php/php-src#13199

Author: petk

bin/make-patches.sh

@@ -26,6 +26,7 @@ patch-cmake-8.4
 patch-cmake-8.4-dmalloc
 patch-cmake-8.4-docs
 patch-cmake-8.4-phpdbg-local-console
+patch-cmake-8.4-typedef-warnings
 "
 php_versions="8.3 8.4"
 

patches/8.4/typedef-warnings.patch

@@ -0,0 +1,24 @@
+diff --git a/Zend/zend_frameless_function.h b/Zend/zend_frameless_function.h
+index 6821654bc4..94e9812ed9 100644
+--- a/Zend/zend_frameless_function.h
++++ b/Zend/zend_frameless_function.h
+@@ -26,7 +26,7 @@
+ # include <php_config.h>
+ #endif
+ 
+-#include "zend_portability.h"
++#include "zend_types.h"
+ 
+ #define ZEND_FRAMELESS_FUNCTION_PARAMETERS_0 zval *return_value
+ #define ZEND_FRAMELESS_FUNCTION_PARAMETERS_1 zval *return_value, zval *arg1
+@@ -103,10 +103,6 @@
+ 
+ BEGIN_EXTERN_C()
+ 
+-typedef struct _zval_struct zval;
+-typedef struct _zend_op zend_op;
+-typedef union _zend_function zend_function;
+-
+ typedef void (*zend_frameless_function_0)(zval *return_value);
+ typedef void (*zend_frameless_function_1)(zval *return_value, zval *op1);
+ typedef void (*zend_frameless_function_2)(zval *return_value, zval *op1, zval *op2);

patches/README.md

@@ -21,6 +21,13 @@ CMake.
 
   See https://github.com/php/php-src/pull/13199
 
+* `typedef-warnings.patch`
+
+  This fixes many warnings in the build to make the build experience friendlier
+  due to various compilation flags used in some cases. It was decided to not
+  port upstream but is kept here until C11 is the standard used in PHP:
+  https://github.com/php/php-src/pull/13347
+
 ## PHP 8.3
 
 * `cmake.patch`