Skip to content

Commit bb35664

Browse files
sagikazarmarksagikazarmark
committed
CS fixes
1 parent 14c629f commit bb35664

File tree

8 files changed

+42
-50
lines changed

8 files changed

+42
-50
lines changed

‎.styleci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ preset: symfony
22

33
finder:
44
exclude:
5-
- "spec"
6-
- "Tests"
75
- "Resources"
8-
path:
9-
- "./"
106

117
enabled:
128
- short_array_syntax

‎ClientFactory/ClientFactoryInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
interface ClientFactoryInterface
99
{
1010
/**
11-
* Input an array of configuration to be able to create a HttpClient
11+
* Input an array of configuration to be able to create a HttpClient.
1212
*
1313
* @param array $config
1414
*
1515
* @return \Http\Client\HttpClient
1616
*/
17-
public function createClient(array $config = array());
17+
public function createClient(array $config = []);
1818
}

‎ClientFactory/PluginClientFactory.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
class PluginClientFactory
1313
{
1414
/**
15-
* @param array $plugins
15+
* @param array $plugins
1616
* @param ClientFactoryInterface $factory
17-
* @param array $config
17+
* @param array $config
1818
*
1919
* @return PluginClient
2020
*/
21-
static public function createPluginClient(array $plugins, ClientFactoryInterface $factory, array $config)
21+
public static function createPluginClient(array $plugins, ClientFactoryInterface $factory, array $config)
2222
{
2323
return new PluginClient($factory->createClient($config), $plugins);
2424
}
25-
}
25+
}

‎DependencyInjection/HttplugExtension.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,13 @@ public function load(array $configs, ContainerBuilder $container)
3838
$container->setAlias(sprintf('httplug.%s', $type), $id);
3939
}
4040
$this->configureClients($container, $config);
41-
42-
4341
}
4442

4543
/**
46-
* Configure client services
44+
* Configure client services.
4745
*
4846
* @param ContainerBuilder $container
49-
* @param array $config
47+
* @param array $config
5048
*/
5149
protected function configureClients(ContainerBuilder $container, array $config)
5250
{
@@ -63,13 +61,12 @@ protected function configureClients(ContainerBuilder $container, array $config)
6361
->addArgument($arguments['config']);
6462
} else {
6563
$def->setFactory('Http\HttplugBundle\ClientFactory\PluginClientFactory::createPluginClient')
66-
->addArgument(array_map(function($id) {
64+
->addArgument(array_map(function ($id) {
6765
return new Reference($id);
6866
}, $arguments['plugins']))
6967
->addArgument(new Reference($arguments['factory']))
7068
->addArgument($arguments['config']);
7169
}
72-
7370
}
7471

7572
// Alias the first client to httplug.client.default

‎Exception/InvalidConfiguration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44

55
class InvalidConfiguration extends \Exception
66
{
7-
}
7+
}

‎HttplugBundle.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace Http\HttplugBundle;
44

5-
use Symfony\Component\DependencyInjection\ContainerBuilder;
65
use Symfony\Component\HttpKernel\Bundle\Bundle;
76

87
/**

‎Tests/Unit/DependencyInjection/ConfigurationTest.php

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -23,63 +23,63 @@ protected function getConfiguration()
2323

2424
public function testEmptyConfiguration()
2525
{
26-
$expectedConfiguration = array(
27-
'main_alias' => array(
26+
$expectedConfiguration = [
27+
'main_alias' => [
2828
'client' => 'httplug.client.default',
2929
'message_factory' => 'httplug.message_factory.default',
3030
'uri_factory' => 'httplug.uri_factory.default',
3131
'stream_factory' => 'httplug.stream_factory.default',
32-
),
33-
'classes' => array(
32+
],
33+
'classes' => [
3434
'client' => null,
3535
'message_factory' => null,
3636
'uri_factory' => null,
3737
'stream_factory' => null,
38-
),
39-
'clients'=>array(),
40-
);
38+
],
39+
'clients' => [],
40+
];
4141

4242
$formats = array_map(function ($path) {
4343
return __DIR__.'/../../Resources/Fixtures/'.$path;
44-
}, array(
44+
}, [
4545
'config/empty.yml',
4646
'config/empty.xml',
4747
'config/empty.php',
48-
));
48+
]);
4949

5050
foreach ($formats as $format) {
51-
$this->assertProcessedConfigurationEquals($expectedConfiguration, array($format));
51+
$this->assertProcessedConfigurationEquals($expectedConfiguration, [$format]);
5252
}
5353
}
5454

5555
public function testSupportsAllConfigFormats()
5656
{
57-
$expectedConfiguration = array(
58-
'main_alias' => array(
57+
$expectedConfiguration = [
58+
'main_alias' => [
5959
'client' => 'my_client',
6060
'message_factory' => 'my_message_factory',
6161
'uri_factory' => 'my_uri_factory',
6262
'stream_factory' => 'my_stream_factory',
63-
),
64-
'classes' => array(
63+
],
64+
'classes' => [
6565
'client' => 'Http\Adapter\Guzzle6\Client',
6666
'message_factory' => 'Http\Message\MessageFactory\GuzzleMessageFactory',
6767
'uri_factory' => 'Http\Message\UriFactory\GuzzleUriFactory',
6868
'stream_factory' => 'Http\Message\StreamFactory\GuzzleStreamFactory',
69-
),
70-
'clients'=>array(),
71-
);
69+
],
70+
'clients' => [],
71+
];
7272

7373
$formats = array_map(function ($path) {
7474
return __DIR__.'/../../Resources/Fixtures/'.$path;
75-
}, array(
75+
}, [
7676
'config/full.yml',
7777
'config/full.xml',
7878
'config/full.php',
79-
));
79+
]);
8080

8181
foreach ($formats as $format) {
82-
$this->assertProcessedConfigurationEquals($expectedConfiguration, array($format));
82+
$this->assertProcessedConfigurationEquals($expectedConfiguration, [$format]);
8383
}
8484
}
8585

@@ -90,6 +90,6 @@ public function testSupportsAllConfigFormats()
9090
public function testMissingClass()
9191
{
9292
$file = __DIR__.'/../../Resources/Fixtures/config/invalid.yml';
93-
$this->assertProcessedConfigurationEquals(array(), array($file));
93+
$this->assertProcessedConfigurationEquals([], [$file]);
9494
}
9595
}

‎Tests/Unit/DependencyInjection/HttplugExtensionTest.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ class HttplugExtensionTest extends AbstractExtensionTestCase
1212
{
1313
protected function getContainerExtensions()
1414
{
15-
return array(
15+
return [
1616
new HttplugExtension(),
17-
);
17+
];
1818
}
1919

2020
public function testConfigLoadDefault()
@@ -33,11 +33,11 @@ public function testConfigLoadDefault()
3333

3434
public function testConfigLoadClass()
3535
{
36-
$this->load(array(
37-
'classes' => array(
38-
'client' => 'Http\Adapter\Guzzle6\Client'
39-
),
40-
));
36+
$this->load([
37+
'classes' => [
38+
'client' => 'Http\Adapter\Guzzle6\Client',
39+
],
40+
]);
4141

4242
foreach (['client', 'message_factory', 'uri_factory', 'stream_factory'] as $type) {
4343
$this->assertContainerBuilderHasAlias("httplug.$type", "httplug.$type.default");
@@ -51,14 +51,14 @@ public function testConfigLoadClass()
5151

5252
public function testConfigLoadService()
5353
{
54-
$this->load(array(
55-
'main_alias' => array(
54+
$this->load([
55+
'main_alias' => [
5656
'client' => 'my_client_service',
5757
'message_factory' => 'my_message_factory_service',
5858
'uri_factory' => 'my_uri_factory_service',
5959
'stream_factory' => 'my_stream_factory_service',
60-
),
61-
));
60+
],
61+
]);
6262

6363
foreach (['client', 'message_factory', 'uri_factory', 'stream_factory'] as $type) {
6464
$this->assertContainerBuilderHasAlias("httplug.$type", "my_{$type}_service");

0 commit comments

Comments
 (0)