Skip to content

Commit 7656a55

Browse files
authored
Merge pull request #155 from Nyholm/exceptions-final
Made exceptions final
2 parents bd7bd89 + b139c50 commit 7656a55

7 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
(These interfaces use the `Interface` suffix to avoid name collisions.)
1212
- Added an interface for HttpClientPool and moved the abstract class to the HttpClientPool sub namespace.
1313
- AddPathPlugin: Do not add the prefix if the URL already has the same prefix.
14+
- All exceptions in `Http\Client\Common\Exception` are final.
1415

1516
### Removed
1617
- Deprecated option `debug_plugins` has been removed from `PluginClient`

src/Exception/CircularRedirectionException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
*
1212
* @author Joel Wurtz <[email protected]>
1313
*/
14-
class CircularRedirectionException extends HttpException
14+
final class CircularRedirectionException extends HttpException
1515
{
1616
}

src/Exception/ClientErrorException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
*
1212
* @author Joel Wurtz <[email protected]>
1313
*/
14-
class ClientErrorException extends HttpException
14+
final class ClientErrorException extends HttpException
1515
{
1616
}

src/Exception/HttpClientNotFoundException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
*
1212
* @author Joel Wurtz <[email protected]>
1313
*/
14-
class HttpClientNotFoundException extends TransferException
14+
final class HttpClientNotFoundException extends TransferException
1515
{
1616
}

src/Exception/LoopException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
*
1212
* @author Joel Wurtz <[email protected]>
1313
*/
14-
class LoopException extends RequestException
14+
final class LoopException extends RequestException
1515
{
1616
}

src/Exception/MultipleRedirectionException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
*
1212
* @author Joel Wurtz <[email protected]>
1313
*/
14-
class MultipleRedirectionException extends HttpException
14+
final class MultipleRedirectionException extends HttpException
1515
{
1616
}

src/Exception/ServerErrorException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
*
1212
* @author Joel Wurtz <[email protected]>
1313
*/
14-
class ServerErrorException extends HttpException
14+
final class ServerErrorException extends HttpException
1515
{
1616
}

0 commit comments

Comments
 (0)