Make clients final

Make not-yet-released clients final

Update changelog

Remove TODOs in favor of #20

Author: sagikazarmark

CHANGELOG.md

@@ -7,6 +7,10 @@
 - Add a flexible http client providing both contract, and only emulating what's necessary
 - HTTP Client Router: route requests to underlying clients
 
+### Deprecated
+
+- Extending client classes, they will be made final in version 2.0
+
 
 ## 1.0.0 - 2016-01-27
 

spec/FlexibleHttpClientSpec.php

@@ -2,16 +2,12 @@
 
 namespace spec\Http\Client\Common;
 
-use Http\Client\Common\HttpAsyncClientDecorator;
-use Http\Client\Common\HttpClientDecorator;
-use Http\Client\Common\FlexibleHttpClient;
 use Http\Client\HttpAsyncClient;
 use Http\Client\HttpClient;
 use Http\Promise\Promise;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Prophet;
 
 class FlexibleHttpClientSpec extends ObjectBehavior
 {
@@ -79,7 +75,7 @@ function it_emulates_a_client(
         $this->sendRequest($syncRequest)->shouldReturn($syncResponse);
     }
 
-    function it_does_not_emulate_a_client(FlexibleHttpClient $client, RequestInterface $syncRequest, RequestInterface $asyncRequest)
+    function it_does_not_emulate_a_client(CombinedHttpClient $client, RequestInterface $syncRequest, RequestInterface $asyncRequest)
     {
         $client->sendRequest($syncRequest)->shouldBeCalled();
         $client->sendRequest($asyncRequest)->shouldNotBeCalled();
@@ -92,3 +88,22 @@ function it_does_not_emulate_a_client(FlexibleHttpClient $client, RequestInterfa
         $this->sendAsyncRequest($asyncRequest);
     }
 }
+
+class CombinedHttpClient implements HttpClient, HttpAsyncClient
+{
+    /**
+     * @param RequestInterface $request
+     */
+    public function sendRequest(RequestInterface $request)
+    {
+        // TODO: Implement sendRequest() method.
+    }
+
+    /**
+     * @param RequestInterface $request
+     */
+    public function sendAsyncRequest(RequestInterface $request)
+    {
+        // TODO: Implement sendAsyncRequest() method.
+    }
+}

src/FlexibleHttpClient.php

@@ -11,7 +11,7 @@
  *
  * @author Joel Wurtz <[email protected]>
  */
-class FlexibleHttpClient implements HttpClient, HttpAsyncClient
+final class FlexibleHttpClient implements HttpClient, HttpAsyncClient
 {
     use HttpClientDecorator;
     use HttpAsyncClientDecorator;