Make regex request matcher final, improve tests

Author: sagikazarmark

spec/RequestMatcher/RegexRequestMatcherSpec.php

@@ -3,9 +3,9 @@
 namespace spec\Http\Message\RequestMatcher;
 
 use Http\Message\RequestMatcher;
-use PhpSpec\ObjectBehavior;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
+use PhpSpec\ObjectBehavior;
 
 class RegexRequestMatcherSpec extends ObjectBehavior
 {
@@ -14,17 +14,17 @@ function let($regex)
         $this->beConstructedWith($regex);
     }
 
-    function it_is_a_request_matcher()
+    function it_is_initializable()
     {
-        $this->shouldImplement('Http\Message\RequestMatcher');
+        $this->shouldHaveType('Http\Message\RequestMatcher\RegexRequestMatcher');
     }
 
-    function it_is_initializable()
+    function it_is_a_request_matcher()
     {
-        $this->shouldHaveType('Http\Message\RequestMatcher\RegexRequestMatcher');
+        $this->shouldImplement('Http\Message\RequestMatcher');
     }
 
-    function it_matches(RequestInterface $request, UriInterface $uri)
+    function it_matches_a_request(RequestInterface $request, UriInterface $uri)
     {
         $this->beConstructedWith('/test/');
 
@@ -34,7 +34,7 @@ function it_matches(RequestInterface $request, UriInterface $uri)
         $this->matches($request)->shouldReturn(true);
     }
 
-    function it_does_not_match(RequestInterface $request, UriInterface $uri)
+    function it_does_not_match_a_request(RequestInterface $request, UriInterface $uri)
     {
         $this->beConstructedWith('/test/');
 

src/RequestMatcher/RegexRequestMatcher.php

@@ -10,7 +10,7 @@
  *
  * @author Joel Wurtz <[email protected]>
  */
-class RegexRequestMatcher implements RequestMatcher
+final class RegexRequestMatcher implements RequestMatcher
 {
     /**
      * Matching regex.