Replace PHPSpec with PHPUnit

PHPSpec blocks the upgrade to Symfony 6. Replacing it with the industry standard PHPUnit.
This makes it way easier for contributors to work on the code.

Author: ruudk

.github/workflows/tests.yml

@@ -88,13 +88,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          composer require "friends-of-phpspec/phpspec-code-coverage:^6.1.0" --no-interaction --no-update
           composer update --prefer-dist --no-interaction --no-progress
 
       - name: Execute tests
-        run: composer test-ci
-
-      - name: Upload coverage
-        run: |
-          wget https://scrutinizer-ci.com/ocular.phar
-          php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml
+        run: composer test

.scrutinizer.yml

@@ -16,16 +16,21 @@
         "php-http/client-common": "^1.9 || ^2.0"
     },
     "require-dev": {
-        "phpspec/phpspec": "^7.0"
+        "symfony/phpunit-bridge": "^5.3",
+        "guzzlehttp/psr7": "^2.1"
     },
     "autoload": {
         "psr-4": {
             "Http\\Client\\Common\\Plugin\\": "src/"
         }
     },
+    "autoload-dev": {
+        "psr-4": {
+            "Http\\Client\\Common\\Plugin\\Tests\\": "tests/"
+        }
+    },
     "scripts": {
-        "test": "vendor/bin/phpspec run",
-        "test-ci": "vendor/bin/phpspec run -c phpspec.yml.ci"
+        "test": "vendor/bin/simple-phpunit"
     },
     "extra": {
         "branch-alias": {

composer.json

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" bootstrap="./vendor/autoload.php" colors="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true">
+  <coverage>
+    <include>
+      <directory>./</directory>
+    </include>
+    <exclude>
+      <directory>./Resources</directory>
+      <directory>./tests</directory>
+      <directory>./vendor</directory>
+    </exclude>
+  </coverage>
+  <php>
+    <env name="SHELL_VERBOSITY" value="-1"/>
+  </php>
+  <testsuites>
+    <testsuite name="StopwatchPlugin unit tests">
+      <directory suffix="Test.php">./tests/Unit</directory>
+    </testsuite>
+  </testsuites>
+</phpunit>

phpspec.yml.ci

@@ -0,0 +1,83 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Http\Client\Common\Plugin\Tests\Unit;
+
+use GuzzleHttp\Psr7\Request;
+use GuzzleHttp\Psr7\Response;
+use Http\Client\Common\Plugin\StopwatchPlugin;
+use Http\Client\Exception\HttpException;
+use Http\Promise\FulfilledPromise;
+use Http\Promise\RejectedPromise;
+use LogicException;
+use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\RequestInterface;
+use Symfony\Component\Stopwatch\Stopwatch;
+
+final class StopwatchPluginTest extends TestCase
+{
+    /**
+     * @var Stopwatch
+     */
+    private $stopwatch;
+
+    /**
+     * @var StopwatchPlugin
+     */
+    private $plugin;
+
+    public function setUp(): void
+    {
+        $this->stopwatch = new Stopwatch();
+        $this->plugin = new StopwatchPlugin($this->stopwatch);
+    }
+
+    /**
+     * @test
+     */
+    public function it_records_event(): void
+    {
+        // Arrange
+        $request = new Request('GET', 'https://localhost');
+        $response = new Response();
+
+        $next = function (RequestInterface $request) use ($response) {
+            return new FulfilledPromise($response);
+        };
+        $first = function (RequestInterface $request) {
+            throw new LogicException('Should not be called');
+        };
+
+        // Act
+        $this->plugin->handleRequest($request, $next, $first);
+
+        // Assert
+        $this->assertCount(1, $this->stopwatch->getSections());
+        $this->assertFalse($this->stopwatch->getSectionEvents('__root__')['GET https://localhost']->isStarted());
+    }
+
+    /**
+     * @test
+     */
+    public function it_records_event_on_error(): void
+    {
+        // Arrange
+        $request = new Request('GET', 'https://localhost');
+        $response = new Response();
+
+        $next = function (RequestInterface $request) use ($response) {
+            return new RejectedPromise(new HttpException('', $request, $response));
+        };
+        $first = function (RequestInterface $request) {
+            throw new LogicException('Should not be called');
+        };
+
+        // Act
+        $this->plugin->handleRequest($request, $next, $first);
+
+        // Assert
+        $this->assertCount(1, $this->stopwatch->getSections());
+        $this->assertFalse($this->stopwatch->getSectionEvents('__root__')['GET https://localhost']->isStarted());
+    }
+}