Skip to content

Commit 05e1d65

Browse files
committed
Revert "Enable -Wimplicit-fallthrough=5 such that no comment is valid"
And realisticly we cannot use such a strict level due to a couple of reasons: PCRE and libmagic use "proper" fallthrough comments which work with the default level (i.e. 3). We could patch libmagic as there is only one occurance and lower the level specifically for PCRE to 3 (or even maybe 4) But Bison generates parsers which use Fallthrough comments anyways This reverts commit cacea41.
1 parent 39374cf commit 05e1d65

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Zend/Zend.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ else
212212
AC_DEFINE(ZEND_DEBUG,0,[ ])
213213
fi
214214
215-
test -n "$GCC" && CFLAGS="-Wall -Wextra -Wimplicit-fallthrough=5 -Wno-strict-aliasing -Wno-unused-parameter -Wno-sign-compare $CFLAGS"
215+
test -n "$GCC" && CFLAGS="-Wall -Wextra -Wno-strict-aliasing -Wno-unused-parameter -Wno-sign-compare $CFLAGS"
216216
dnl Check if compiler supports -Wno-clobbered (only GCC)
217217
AX_CHECK_COMPILE_FLAG([-Wno-clobbered], CFLAGS="-Wno-clobbered $CFLAGS", , [-Werror])
218218

0 commit comments

Comments
 (0)