Skip to content

Commit 06a89a9

Browse files
committed
Make readonly error message consistent
1 parent b68b55b commit 06a89a9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ext/xmlreader/php_xmlreader.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ zval *xmlreader_write_property(zend_object *object, zend_string *name, zval *val
172172
hnd = zend_hash_find_ptr(obj->prop_handler, name);
173173
}
174174
if (hnd != NULL) {
175-
zend_throw_error(NULL, "Cannot write to read-only property");
175+
zend_throw_error(NULL, "Cannot modify readonly property %s::$%s", ZSTR_VAL(object->ce->name), ZSTR_VAL(name));
176176
} else {
177177
value = zend_std_write_property(object, name, value, cache_slot);
178178
}

ext/xmlreader/tests/014.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,6 @@ $reader->close();
5454
unlink(__DIR__.'/_014.xml');
5555
?>
5656
--EXPECT--
57-
Cannot write to read-only property
58-
Cannot write to read-only property
59-
Cannot write to read-only property
57+
Cannot modify readonly property XMLReader::$value
58+
Cannot modify readonly property XMLReader::$value
59+
Cannot modify readonly property XMLReader::$name

0 commit comments

Comments
 (0)