Skip shebang in cli-server router script

iluuu1994 · iluuu1994 · commit 06efe44c2ebd · 2024-10-14T13:33:16.000+02:00
Fixes GH-16373 Closes GH-16403
diff --git a/NEWS b/NEWS
@@ -2,6 +2,10 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? ????, PHP 8.2.26
 
+- Cli:
+  . Fixed bug GH-16373 (Shebang is not skipped for router script in cli-server
+    started through shebang). (ilutov)
+
 - COM:
   . Fixed out of bound writes to SafeArray data. (cmb)
 
diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
@@ -2271,6 +2271,7 @@ static int php_cli_server_dispatch_router(php_cli_server *server, php_cli_server
 		}
 
 		ZVAL_UNDEF(&retval);
+		CG(skip_shebang) = true;
 		if (SUCCESS == zend_execute_scripts(ZEND_REQUIRE, &retval, 1, &zfd)) {
 			if (Z_TYPE(retval) != IS_UNDEF) {
 				decline = Z_TYPE(retval) == IS_FALSE;

Original file line number	Diff line number	Diff line change
`@@ -2271,6 +2271,7 @@ static int php_cli_server_dispatch_router(php_cli_server *server, php_cli_server`
`2271`	`2271`	`}`
`2272`	`2272`
`2273`	`2273`	`ZVAL_UNDEF(&retval);`
	`2274`	`+ CG(skip_shebang) = true;`
`2274`	`2275`	`if (SUCCESS == zend_execute_scripts(ZEND_REQUIRE, &retval, 1, &zfd)) {`
`2275`	`2276`	`if (Z_TYPE(retval) != IS_UNDEF) {`
`2276`	`2277`	`decline = Z_TYPE(retval) == IS_FALSE;`