Fix string container behaviour test

Author: Girgias

Zend/tests/offsets/string_container_offset_behaviour.phpt

@@ -1,7 +1,5 @@
 --TEST--
 String containers behaviour with offsets
---XFAIL--
-INF offset on string doesn't behave like other floats for isset()/empty()
 --FILE--
 <?php
 
@@ -30,6 +28,33 @@ OUTPUT;
 
 $EXPECTED_OUTPUT_VALID_OFFSETS_REGEX = '/^' . expectf_to_regex(EXPECTED_OUTPUT_VALID_OFFSETS) . '$/s';
 
+const EXPECTED_OUTPUT_VALID_OFFSETS_OUT_OF_RANGE = <<<OUTPUT
+Read before write:
+
+Warning: Uninitialized string offset %i in %s on line 8
+string(0) ""
+Write:
+
+Warning: Illegal string offset %i in %s on line 15
+Read:
+
+Warning: Uninitialized string offset %i in %s on line 22
+string(0) ""
+Read-Write:
+Cannot use assign-op operators with string offsets
+isset():
+bool(false)
+empty():
+bool(true)
+Coalesce():
+string(7) "default"
+unset():
+Cannot unset string offsets
+
+OUTPUT;
+
+$EXPECTED_OUTPUT_VALID_OFFSETS_OUT_OF_RANGE_REGEX = '/^' . expectf_to_regex(EXPECTED_OUTPUT_VALID_OFFSETS_OUT_OF_RANGE) . '$/s';
+
 const EXPECTED_OUTPUT_STRING_CAST_OFFSETS = <<<OUTPUT
 Read before write:
 
@@ -61,6 +86,41 @@ OUTPUT;
 
 $EXPECTED_OUTPUT_STRING_CAST_OFFSETS_REGEX = '/^' . expectf_to_regex(EXPECTED_OUTPUT_STRING_CAST_OFFSETS) . '$/s';
 
+const EXPECTED_OUTPUT_STRING_CAST_OFFSETS_OUT_OF_RANGE = <<<OUTPUT
+Read before write:
+
+Warning: String offset cast occurred in %s on line 8
+
+Warning: Uninitialized string offset %i in %s on line 8
+string(0) ""
+Write:
+
+Warning: String offset cast occurred in %s on line 15
+
+Warning: Illegal string offset %i in %s on line 15
+Read:
+
+Warning: String offset cast occurred in %s on line 22
+
+Warning: Uninitialized string offset %i in %s on line 22
+string(0) ""
+Read-Write:
+
+Warning: String offset cast occurred in %s on line 29
+Cannot use assign-op operators with string offsets
+isset():
+bool(false)
+empty():
+bool(true)
+Coalesce():
+string(7) "default"
+unset():
+Cannot unset string offsets
+
+OUTPUT;
+
+$EXPECTED_OUTPUT_STRING_CAST_OFFSETS_OUT_OF_RANGE_REGEX = '/^' . expectf_to_regex(EXPECTED_OUTPUT_STRING_CAST_OFFSETS_OUT_OF_RANGE) . '$/s';
+
 const EXPECTF_OUTPUT_FLOAT_OFFSETS = <<<OUTPUT
 Read before write:
 
@@ -88,16 +148,53 @@ empty():
 Deprecated: Implicit conversion from float %F to int loses precision in %s on line 42
 bool(false)
 Coalesce():
-
-Deprecated: Implicit conversion from float %F to int loses precision in %s on line 48
-string(7) "vappend"
+string(1) "v"
 unset():
 Cannot unset string offsets
 
 OUTPUT;
 
 $EXPECTED_OUTPUT_FLOAT_OFFSETS_REGEX = '/^' . expectf_to_regex(EXPECTF_OUTPUT_FLOAT_OFFSETS) . '$/s';
 
+const EXPECTF_OUTPUT_FLOAT_OFFSETS_OUT_OF_RANGE = <<<OUTPUT
+Read before write:
+
+Warning: String offset cast occurred in %s on line 8
+
+Warning: Uninitialized string offset %i in %s on line 8
+string(0) ""
+Write:
+
+Warning: String offset cast occurred in %s on line 15
+
+Warning: Illegal string offset %i in %s on line 15
+Read:
+
+Warning: String offset cast occurred in %s on line 22
+
+Warning: Uninitialized string offset %i in %s on line 22
+string(0) ""
+Read-Write:
+
+Warning: String offset cast occurred in %s on line 29
+Cannot use assign-op operators with string offsets
+isset():
+
+Deprecated: Implicit conversion from float %F to int loses precision in %s on line 36
+bool(false)
+empty():
+
+Deprecated: Implicit conversion from float %F to int loses precision in %s on line 42
+bool(true)
+Coalesce():
+string(7) "default"
+unset():
+Cannot unset string offsets
+
+OUTPUT;
+
+$EXPECTF_OUTPUT_FLOAT_OFFSETS_OUT_OF_RANGE_REGEX = '/^' . expectf_to_regex(EXPECTF_OUTPUT_FLOAT_OFFSETS_OUT_OF_RANGE) . '$/s';
+
 const EXPECTED_OUTPUT_INVALID_OFFSETS = <<<OUTPUT
 Read before write:
 Cannot access offset of type %s on string
@@ -189,13 +286,16 @@ foreach ($offsets as $dimension) {
 
     if (
         !preg_match($EXPECTED_OUTPUT_VALID_OFFSETS_REGEX, $varOutput)
+        && !preg_match($EXPECTED_OUTPUT_VALID_OFFSETS_OUT_OF_RANGE_REGEX, $varOutput)
         && !preg_match($EXPECTED_OUTPUT_STRING_CAST_OFFSETS_REGEX, $varOutput)
-        && !preg_match($EXPECTED_OUTPUT_INVALID_OFFSETS_REGEX, $varOutput)
+        && !preg_match($EXPECTED_OUTPUT_STRING_CAST_OFFSETS_OUT_OF_RANGE_REGEX, $varOutput)
         && !preg_match($EXPECTED_OUTPUT_FLOAT_OFFSETS_REGEX, $varOutput)
+        && !preg_match($EXPECTF_OUTPUT_FLOAT_OFFSETS_OUT_OF_RANGE_REGEX, $varOutput)
+        && !preg_match($EXPECTED_OUTPUT_INVALID_OFFSETS_REGEX, $varOutput)
         && $varOutput !== EXPECTED_OUTPUT_INVALID_OFFSETS_AS_STRINGS
         && !preg_match($EXPECTED_OUTPUT_INVALID_OFFSETS_AS_LEADING_NUMERIC_STRINGS_REGEX, $varOutput)
     ) {
-        //file_put_contents(__DIR__ . DIRECTORY_SEPARATOR . "debug_string_container_{$failuresNb}.txt", $varOutput);
+        file_put_contents(__DIR__ . DIRECTORY_SEPARATOR . "debug_string_container_{$failuresNb}.txt", $varOutput);
         ++$failuresNb;
         $failures[] = $error;
     }