Add libxml2 bug workaround

nielsdos · nielsdos · commit 0caa18114d52 · 2023-09-23T19:40:47.000+02:00
diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c
@@ -498,6 +498,12 @@ static void dom_update_refcount_after_clone(dom_object *original, xmlNodePtr ori
 	php_libxml_increment_node_ptr((php_libxml_node_object *)clone, cloned_node, (void *)clone);
 	if (original->document != clone->document) {
 		dom_copy_doc_props(original->document, clone->document);
+		/* Workaround libxml2 bug, see https://gitlab.gnome.org/GNOME/libxml2/-/commit/07920b4381873187c02df53fa9b5d44aff3a7041 */
+#if LIBXML_VERSION < 20911
+		if (original_node->type == XML_HTML_DOCUMENT_NODE) {
+			cloned_node->type = XML_HTML_DOCUMENT_NODE;
+		}
+#endif
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -498,6 +498,12 @@ static void dom_update_refcount_after_clone(dom_object *original, xmlNodePtr ori`
`498`	`498`	`php_libxml_increment_node_ptr((php_libxml_node_object )clone, cloned_node, (void )clone);`
`499`	`499`	`if (original->document != clone->document) {`
`500`	`500`	`dom_copy_doc_props(original->document, clone->document);`
	`501`	`+ /* Workaround libxml2 bug, see https://gitlab.gnome.org/GNOME/libxml2/-/commit/07920b4381873187c02df53fa9b5d44aff3a7041 */`
	`502`	`+#if LIBXML_VERSION < 20911`
	`503`	`+ if (original_node->type == XML_HTML_DOCUMENT_NODE) {`
	`504`	`+ cloned_node->type = XML_HTML_DOCUMENT_NODE;`
	`505`	`+ }`
	`506`	`+#endif`
`501`	`507`	`}`
`502`	`508`	`}`
`503`	`509`