Add ctype_tolower() and ctype_toupper()

Reintroduce the old strtolower() and strtoupper() functions with new
names ctype_tolower() and ctype_toupper(). Use the old test cases.

Author: tstarling

ext/ctype/ctype.c

@@ -24,6 +24,7 @@
 #include "ctype_arginfo.h"
 #include "SAPI.h"
 #include "ext/standard/info.h"
+#include "ext/standard/basic_functions.h"
 
 #include <ctype.h>
 
@@ -176,4 +177,86 @@ PHP_FUNCTION(ctype_xdigit)
 }
 /* }}} */
 
+/* {{{ Converts a string to lower case */
+PHP_FUNCTION(ctype_tolower)
+{
+	zend_string *s;
+	unsigned char *c;
+	const unsigned char *e;
+
+	ZEND_PARSE_PARAMETERS_START(1, 1)
+		Z_PARAM_STR(s)
+	ZEND_PARSE_PARAMETERS_END();
+
+	if (EXPECTED(!BG(ctype_string))) {
+		RETURN_STR(zend_string_tolower(s));
+	} else {
+		c = (unsigned char *)ZSTR_VAL(s);
+		e = c + ZSTR_LEN(s);
+
+		while (c < e) {
+			if (isupper(*c)) {
+				unsigned char *r;
+				zend_string *res = zend_string_alloc(ZSTR_LEN(s), 0);
+
+				if (c != (unsigned char*)ZSTR_VAL(s)) {
+					memcpy(ZSTR_VAL(res), ZSTR_VAL(s), c - (unsigned char*)ZSTR_VAL(s));
+				}
+				r = c + (ZSTR_VAL(res) - ZSTR_VAL(s));
+				while (c < e) {
+					*r = tolower(*c);
+					r++;
+					c++;
+				}
+				*r = '\0';
+				RETURN_STR(res);
+			}
+			c++;
+		}
+		RETURN_STR_COPY(s);
+	}
+}
+/* }}} */
+
+/* {{{ Converts a string to upper case */
+PHP_FUNCTION(ctype_toupper)
+{
+	zend_string *s;
+	unsigned char *c;
+	const unsigned char *e;
+
+	ZEND_PARSE_PARAMETERS_START(1, 1)
+		Z_PARAM_STR(s)
+	ZEND_PARSE_PARAMETERS_END();
+
+	if (EXPECTED(!BG(ctype_string))) {
+		RETURN_STR(zend_string_toupper(s));
+	} else {
+		c = (unsigned char *)ZSTR_VAL(s);
+		e = c + ZSTR_LEN(s);
+
+		while (c < e) {
+			if (islower(*c)) {
+				unsigned char *r;
+				zend_string *res = zend_string_alloc(ZSTR_LEN(s), 0);
+
+				if (c != (unsigned char*)ZSTR_VAL(s)) {
+					memcpy(ZSTR_VAL(res), ZSTR_VAL(s), c - (unsigned char*)ZSTR_VAL(s));
+				}
+				r = c + (ZSTR_VAL(res) - ZSTR_VAL(s));
+				while (c < e) {
+					*r = toupper(*c);
+					r++;
+					c++;
+				}
+				*r = '\0';
+				RETURN_STR(res);
+			}
+			c++;
+		}
+		RETURN_STR_COPY(s);
+	}
+}
+/* }}} */
+
 #endif	/* HAVE_CTYPE */

ext/ctype/ctype.stub.php

@@ -23,3 +23,7 @@ function ctype_space(mixed $text): bool {}
 function ctype_upper(mixed $text): bool {}
 
 function ctype_xdigit(mixed $text): bool {}
+
+function ctype_tolower(string $text): string {}
+
+function ctype_toupper(string $text): string {}

ext/ctype/ctype_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 155783e1858a7f24dbc1c3e810d5cffee5468bf7 */
+ * Stub hash: f722fd029c16401b071bd0ec8c1bca4380675d23 */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ctype_alnum, 0, 1, _IS_BOOL, 0)
 	ZEND_ARG_TYPE_INFO(0, text, IS_MIXED, 0)
@@ -25,6 +25,12 @@ ZEND_END_ARG_INFO()
 
 #define arginfo_ctype_xdigit arginfo_ctype_alnum
 
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ctype_tolower, 0, 1, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, text, IS_STRING, 0)
+ZEND_END_ARG_INFO()
+
+#define arginfo_ctype_toupper arginfo_ctype_tolower
+
 
 ZEND_FUNCTION(ctype_alnum);
 ZEND_FUNCTION(ctype_alpha);
@@ -37,6 +43,8 @@ ZEND_FUNCTION(ctype_punct);
 ZEND_FUNCTION(ctype_space);
 ZEND_FUNCTION(ctype_upper);
 ZEND_FUNCTION(ctype_xdigit);
+ZEND_FUNCTION(ctype_tolower);
+ZEND_FUNCTION(ctype_toupper);
 
 
 static const zend_function_entry ext_functions[] = {
@@ -51,5 +59,7 @@ static const zend_function_entry ext_functions[] = {
 	ZEND_FE(ctype_space, arginfo_ctype_space)
 	ZEND_FE(ctype_upper, arginfo_ctype_upper)
 	ZEND_FE(ctype_xdigit, arginfo_ctype_xdigit)
+	ZEND_FE(ctype_tolower, arginfo_ctype_tolower)
+	ZEND_FE(ctype_toupper, arginfo_ctype_toupper)
 	ZEND_FE_END
 };