avoid needless function call

weltling · weltling · commit 1d64b4c71e93 · 2016-09-01T23:45:31.000+02:00
diff --git a/ext/standard/array.c b/ext/standard/array.c
@@ -2398,7 +2398,6 @@ static void php_array_data_shuffle(zval *array) /* {{{ */
 			}
 		}
 		while (--n_left) {
-			rnd_idx = php_rand();
 			RAND_RANGE(rnd_idx, 0, n_left, PHP_RAND_MAX);
 			if (rnd_idx != n_left) {
 				temp = hash->arData[n_left];
@@ -2424,7 +2423,6 @@ static void php_array_data_shuffle(zval *array) /* {{{ */
 			}
 		}
 		while (--n_left) {
-			rnd_idx = php_rand();
 			RAND_RANGE(rnd_idx, 0, n_left, PHP_RAND_MAX);
 			if (rnd_idx != n_left) {
 				temp = hash->arData[n_left];

Original file line number	Diff line number	Diff line change
`@@ -2398,7 +2398,6 @@ static void php_array_data_shuffle(zval array) / {{{ */`
`2398`	`2398`	`}`
`2399`	`2399`	`}`
`2400`	`2400`	`while (--n_left) {`
`2401`		`- rnd_idx = php_rand();`
`2402`	`2401`	`RAND_RANGE(rnd_idx, 0, n_left, PHP_RAND_MAX);`
`2403`	`2402`	`if (rnd_idx != n_left) {`
`2404`	`2403`	`temp = hash->arData[n_left];`
`@@ -2424,7 +2423,6 @@ static void php_array_data_shuffle(zval array) / {{{ */`
`2424`	`2423`	`}`
`2425`	`2424`	`}`
`2426`	`2425`	`while (--n_left) {`
`2427`		`- rnd_idx = php_rand();`
`2428`	`2426`	`RAND_RANGE(rnd_idx, 0, n_left, PHP_RAND_MAX);`
`2429`	`2427`	`if (rnd_idx != n_left) {`
`2430`	`2428`	`temp = hash->arData[n_left];`