add test

Author: devnexen

ext/pgsql/pgsql.c

@@ -2150,13 +2150,15 @@ PHP_FUNCTION(pg_trace)
 	PQtrace(pgsql, fp);
 	if (trace_mode > 0) {
 #ifdef PQTRACE_REGRESS_MODE
-		if (trace_mode > (PQTRACE_SUPPRESS_TIMESTAMPS|PQTRACE_REGRESS_MODE)) {
-			zend_argument_value_error(2, "must be PGSQL_TRACE_SUPPRESS_TIMESTAMPS and/or PGSQL_TRACE_REGRESS_MODE");
+		if (!(trace_mode & (PQTRACE_SUPPRESS_TIMESTAMPS|PQTRACE_REGRESS_MODE))) {
+			zend_argument_value_error(4, "must be PGSQL_TRACE_SUPPRESS_TIMESTAMPS and/or PGSQL_TRACE_REGRESS_MODE");
+			RETURN_THROWS();
 		} else {
 			PQsetTraceFlags(pgsql, trace_mode);
 		}
 #else
-		zend_argument_value_error(2, "cannot set the trace mode as it's unsupported");
+		zend_argument_value_error(4, "cannot set as trace is unsupported");
+		RETURN_THROWS();
 #endif
 	}
 	RETURN_TRUE;

ext/pgsql/tests/pg_trace.phpt

@@ -0,0 +1,26 @@
+--TEST--
+pg_trace
+--EXTENSIONS--
+pgsql
+--SKIPIF--
+<?php include("skipif.inc"); ?>
+--FILE--
+<?php
+
+include('config.inc');
+
+$db = pg_connect($conn_str);
+$tracefile = __DIR__ . '/trace.tmp';
+
+try {
+	pg_trace($tracefile, 'w', $db, 56432);
+} catch (ValueError $e) {
+	echo $e->getMessage() . PHP_EOL;
+}
+var_dump(pg_trace($tracefile, 'w', $db, 0));
+$res = pg_query($db, 'select 1');
+
+?>
+--EXPECT--
+pg_trace(): Argument #4 ($trace_mode) cannot set as trace is unsupported
+bool(true)