Skip to content

Commit 20ff9ea

Browse files
committed
Use the zend_update_property_*() API instead of a add_property_*()
1 parent eb4322d commit 20ff9ea

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ext/standard/user_filters.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -371,11 +371,11 @@ PHP_FUNCTION(stream_bucket_make_writeable)
371371
if (brigade->head && (bucket = php_stream_bucket_make_writeable(brigade->head))) {
372372
ZVAL_RES(&zbucket, zend_register_resource(bucket, le_bucket));
373373
object_init_ex(return_value, stream_bucket_class_entry);
374-
add_property_zval(return_value, "bucket", &zbucket);
374+
zend_update_property(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("bucket"), &zbucket);
375375
/* add_property_zval increments the refcount which is unwanted here */
376376
zval_ptr_dtor(&zbucket);
377-
add_property_stringl(return_value, "data", bucket->buf, bucket->buflen);
378-
add_property_long(return_value, "datalen", bucket->buflen);
377+
zend_update_property_stringl(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("data"), bucket->buf, bucket->buflen);
378+
zend_update_property_long(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("datalen"), bucket->buflen);
379379
} else {
380380
ZVAL_NULL(return_value);
381381
}
@@ -476,11 +476,11 @@ PHP_FUNCTION(stream_bucket_new)
476476

477477
ZVAL_RES(&zbucket, zend_register_resource(bucket, le_bucket));
478478
object_init_ex(return_value, stream_bucket_class_entry);
479-
add_property_zval(return_value, "bucket", &zbucket);
479+
zend_update_property(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("bucket"), &zbucket);
480480
/* add_property_zval increments the refcount which is unwanted here */
481481
zval_ptr_dtor(&zbucket);
482-
add_property_stringl(return_value, "data", bucket->buf, bucket->buflen);
483-
add_property_long(return_value, "datalen", bucket->buflen);
482+
zend_update_property_stringl(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("data"), bucket->buf, bucket->buflen);
483+
zend_update_property_long(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("datalen"), bucket->buflen);
484484
}
485485
/* }}} */
486486

0 commit comments

Comments
 (0)