Fix memory leak on case of failure

Author: Girgias

Zend/zend_API.c

@@ -1850,11 +1850,14 @@ ZEND_API zend_result object_init_with_constructor(zval *arg, zend_class_entry *c
 {
 	zend_result status = _object_and_properties_init(arg, class_type, NULL);
 	if (UNEXPECTED(status == FAILURE)) {
+		ZVAL_UNDEF(arg);
 		return FAILURE;
 	}
 	zend_object *obj = Z_OBJ_P(arg);
 	zend_function *constructor = obj->handlers->get_constructor(obj);
 	if (UNEXPECTED(constructor == NULL)) {
+		zval_ptr_dtor(arg);
+		ZVAL_UNDEF(arg);
 		return FAILURE;
 	}
 	/* A constructor should not return a value, however if an exception is thrown
@@ -1870,6 +1873,8 @@ ZEND_API zend_result object_init_with_constructor(zval *arg, zend_class_entry *c
 		named_params
 	);
 	if (Z_TYPE(retval) == IS_UNDEF) {
+		zval_ptr_dtor(arg);
+		ZVAL_UNDEF(arg);
 		return FAILURE;
 	} else {
 		/* Unlikely, but user constructors may return any value they want */

ext/zend_test/test.c

@@ -473,11 +473,14 @@ static ZEND_FUNCTION(zend_object_init_with_constructor)
 		Z_PARAM_VARIADIC_WITH_NAMED(args, num_args, named_args)
 	ZEND_PARSE_PARAMETERS_END();
 
-	zend_result status = object_init_with_constructor(return_value, ce, num_args, args, named_args);
+	zval obj;
+	/* We don't use return_value directly to check for memory leaks of the API on failure */
+	zend_result status = object_init_with_constructor(&obj, ce, num_args, args, named_args);
 	if (status == FAILURE) {
 		RETURN_THROWS();
 	}
 	ZEND_ASSERT(!EG(exception));
+	ZVAL_COPY_VALUE(return_value, &obj);
 }
 
 static ZEND_FUNCTION(zend_get_unit_enum)