Implement ZEND_ARRAY_KEY_EXISTS opcode to speed up array_key_exists()

Author: Majkl578

NEWS

@@ -16,6 +16,8 @@ PHP                                                                        NEWS
     logging. (Philip Prindeville)
   . Fixed bug #63217 (Constant numeric strings become integers when used as
     ArrayAccess offset). (Rudi Theunissen)
+  . Implement ZEND_ARRAY_KEY_EXISTS opcode to speed up array_key_exists().
+    (Majkl578)
 
 - DOM:
   . Fixed bug #76285 (DOMDocument::formatOutput attribute sometimes ignored).

Zend/zend_compile.c

@@ -3876,6 +3876,22 @@ int zend_compile_func_get_args(znode *result, zend_ast_list *args) /* {{{ */
 }
 /* }}} */
 
+int zend_compile_func_array_key_exists(znode *result, zend_ast_list *args) /* {{{ */
+{
+	if (args->children != 2) {
+		return FAILURE;
+	}
+
+	znode subject, needle;
+
+	zend_compile_expr(&needle, args->child[0]);
+	zend_compile_expr(&subject, args->child[1]);
+
+	zend_emit_op_tmp(result, ZEND_ARRAY_KEY_EXISTS, &needle, &subject);
+	return SUCCESS;
+}
+/* }}} */
+
 int zend_compile_func_array_slice(znode *result, zend_ast_list *args) /* {{{ */
 {
 	if (CG(active_op_array)->function_name
@@ -3983,6 +3999,8 @@ int zend_try_compile_special_func(znode *result, zend_string *lcname, zend_ast_l
 		return zend_compile_func_get_args(result, args);
 	} else if (zend_string_equals_literal(lcname, "array_slice")) {
 		return zend_compile_func_array_slice(result, args);
+	} else if (zend_string_equals_literal(lcname, "array_key_exists")) {
+		return zend_compile_func_array_key_exists(result, args);
 	} else {
 		return FAILURE;
 	}

Zend/zend_vm_def.h

@@ -6373,6 +6373,60 @@ ZEND_VM_C_LABEL(isset_no_object):
 	ZEND_VM_NEXT_OPCODE_CHECK_EXCEPTION();
 }
 
+ZEND_VM_HANDLER(199, ZEND_ARRAY_KEY_EXISTS, CV|TMPVAR|CONST, CV|TMPVAR|CONST)
+{
+	USE_OPLINE
+
+	zend_free_op free_op1, free_op2;
+	zval *subject, *key;
+	int result;
+
+	SAVE_OPLINE();
+
+	subject = GET_OP2_ZVAL_PTR(BP_VAR_R);
+	key = GET_OP1_ZVAL_PTR(BP_VAR_R);
+
+	if (UNEXPECTED(Z_ISREF_P(subject))) {
+		subject = Z_REFVAL_P(subject);
+	}
+	if (UNEXPECTED(Z_ISREF_P(key))) {
+		key = Z_REFVAL_P(key);
+	}
+
+	if (EXPECTED(Z_TYPE_P(subject) == IS_ARRAY)) {
+		if (EXPECTED(Z_TYPE_P(key) == IS_STRING)) {
+			result = zend_symtable_exists_ind(Z_ARRVAL_P(subject), Z_STR_P(key));
+		} else if (EXPECTED(Z_TYPE_P(key) == IS_LONG)) {
+			result = zend_hash_index_exists(Z_ARRVAL_P(subject), Z_LVAL_P(key));
+		} else if (UNEXPECTED(Z_TYPE_P(key) == IS_NULL)) {
+			result = zend_symtable_exists_ind(Z_ARRVAL_P(subject), ZSTR_EMPTY_ALLOC());
+		} else {
+			zend_error(E_WARNING, "array_key_exists(): The first argument should be either a string or an integer");
+			result = 0;
+		}
+		ZVAL_BOOL(EX_VAR(opline->result.var), result);
+	} else if (UNEXPECTED(Z_TYPE_P(subject) == IS_OBJECT)) {
+		if (EXPECTED(Z_TYPE_P(key) == IS_STRING)) {
+			result = zend_symtable_exists_ind(Z_OBJPROP_P(subject), Z_STR_P(key));
+		} else if (EXPECTED(Z_TYPE_P(key) == IS_LONG)) {
+			result = zend_hash_index_exists(Z_OBJPROP_P(subject), Z_LVAL_P(key));
+		} else if (UNEXPECTED(Z_TYPE_P(key) == IS_NULL)) {
+			result = zend_symtable_exists_ind(Z_OBJPROP_P(subject), ZSTR_EMPTY_ALLOC());
+		} else {
+			zend_error(E_WARNING, "array_key_exists(): The first argument should be either a string or an integer");
+			result = 0;
+		}
+		ZVAL_BOOL(EX_VAR(opline->result.var), result);
+	} else {
+		zend_internal_type_error(EX_USES_STRICT_TYPES(), "array_key_exists() expects parameter 2 to be array, %s given", zend_get_type_by_const(Z_TYPE_P(subject)));
+		ZVAL_NULL(EX_VAR(opline->result.var));
+	}
+
+	FREE_OP2();
+	FREE_OP1();
+	ZEND_VM_NEXT_OPCODE_CHECK_EXCEPTION();
+}
+
 ZEND_VM_COLD_HANDLER(79, ZEND_EXIT, CONST|TMPVAR|UNUSED|CV, ANY)
 {
 	USE_OPLINE