Skip to content

Commit 2323dc2

Browse files
committed
Avoid shell for proc_terminate() test
Otherwise we're sending the signal to the shell, not the sleep process, and it will continue sleeping. This also illustrates a minor issue without our array proc_open() support: We don't preserve the passed arguments in the proc_get_status() output.
1 parent c96be7b commit 2323dc2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/standard/tests/general_functions/proc_open02.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ if (getenv('SKIP_SLOW_TESTS')) echo 'skip slow test';
1010
$ds = array(array('pipe', 'r'));
1111

1212
$cat = proc_open(
13-
'/bin/sleep 2',
13+
['/bin/sleep', '2'],
1414
$ds,
1515
$pipes
1616
);
@@ -34,7 +34,7 @@ echo "Done!\n";
3434
bool(true)
3535
array(8) {
3636
["command"]=>
37-
string(12) "/bin/sleep 2"
37+
string(10) "/bin/sleep"
3838
["pid"]=>
3939
int(%d)
4040
["running"]=>
@@ -53,7 +53,7 @@ array(8) {
5353
bool(true)
5454
array(8) {
5555
["command"]=>
56-
string(12) "/bin/sleep 2"
56+
string(10) "/bin/sleep"
5757
["pid"]=>
5858
int(%d)
5959
["running"]=>

0 commit comments

Comments
 (0)