Skip to content

Commit 2e041de

Browse files
committed
Remove fast_add_function() function
1 parent b2cf406 commit 2e041de

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

UPGRADING.INTERNALS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ PHP 8.3 INTERNALS UPGRADE NOTES
3030
for C99 features have been removed and therefore macro definitions
3131
from php_config.h have disappeared. Do not use those feature
3232
macros.
33+
* The fast_add_function() has been removed, use add_function() that will
34+
call the static inline add_function_fast() instead.
3335

3436
========================
3537
2. Build system changes

Zend/zend_operators.h

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -704,28 +704,6 @@ overflow: ZEND_ATTRIBUTE_COLD_LABEL
704704
#endif
705705
}
706706

707-
static zend_always_inline zend_result fast_add_function(zval *result, zval *op1, zval *op2)
708-
{
709-
if (EXPECTED(Z_TYPE_P(op1) == IS_LONG)) {
710-
if (EXPECTED(Z_TYPE_P(op2) == IS_LONG)) {
711-
fast_long_add_function(result, op1, op2);
712-
return SUCCESS;
713-
} else if (EXPECTED(Z_TYPE_P(op2) == IS_DOUBLE)) {
714-
ZVAL_DOUBLE(result, ((double)Z_LVAL_P(op1)) + Z_DVAL_P(op2));
715-
return SUCCESS;
716-
}
717-
} else if (EXPECTED(Z_TYPE_P(op1) == IS_DOUBLE)) {
718-
if (EXPECTED(Z_TYPE_P(op2) == IS_DOUBLE)) {
719-
ZVAL_DOUBLE(result, Z_DVAL_P(op1) + Z_DVAL_P(op2));
720-
return SUCCESS;
721-
} else if (EXPECTED(Z_TYPE_P(op2) == IS_LONG)) {
722-
ZVAL_DOUBLE(result, Z_DVAL_P(op1) + ((double)Z_LVAL_P(op2)));
723-
return SUCCESS;
724-
}
725-
}
726-
return add_function(result, op1, op2);
727-
}
728-
729707
static zend_always_inline void fast_long_sub_function(zval *result, zval *op1, zval *op2)
730708
{
731709
#if ZEND_USE_ASM_ARITHMETIC && defined(__i386__) && !(4 == __GNUC__ && 8 == __GNUC_MINOR__)

0 commit comments

Comments
 (0)