remove support for getBytesFromString("",0);

for consistency, I would prefer to actually support this, but TimWolla disagrees, and i cba fighting for it (it's an edge-case after all): #12216 (comment)

Author: divinity76

ext/random/randomizer.c

@@ -390,8 +390,8 @@ PHP_METHOD(Random_Randomizer, getBytesFromString)
 	const size_t source_length = ZSTR_LEN(source);
 	const size_t max_offset = source_length - 1;
 
-	if (source_length < 1 && length > 0) {
-		zend_argument_value_error(1, "cannot be empty when argument #2 ($length) is greater than 0");
+	if (source_length < 1) {
+		zend_argument_value_error(1, "cannot be empty");
 		RETURN_THROWS();
 	}
 

ext/random/tests/03_randomizer/methods/getBytes.phpt

@@ -27,7 +27,7 @@ foreach ($engines as $engine) {
     $randomizer = new Randomizer($engine);
 
     // Using 10_000 is very slow.
-    for ($i = 1; $i < 1_000; $i++) {
+    for ($i = 0; $i < 1_000; ++$i) {
         if (\strlen($randomizer->getBytes($i)) !== $i) {
             die("failure: incorrect string length at {$i}");
         }

ext/random/tests/03_randomizer/methods/getBytesFromString.phpt

@@ -27,7 +27,7 @@ foreach ($engines as $engine) {
     $randomizer = new Randomizer($engine);
     var_dump($randomizer->getBytesFromString('a', 10));
     var_dump($randomizer->getBytesFromString(str_repeat('a', 256), 5));
-    var_dump($randomizer->getBytesFromString('', 0));
+    var_dump($randomizer->getBytesFromString('a', 0));
 
     for ($i = 1; $i < 250; $i++) {
         $output = $randomizer->getBytesFromString(str_repeat('ab', $i), 500);

ext/random/tests/03_randomizer/methods/getBytesFromString_error.phpt

@@ -24,5 +24,5 @@ try {
 
 ?>
 --EXPECT--
-Random\Randomizer::getBytesFromString(): Argument #1 ($string) cannot be empty when argument #2 ($length) is greater than 0
+Random\Randomizer::getBytesFromString(): Argument #1 ($string) cannot be empty
 Random\Randomizer::getBytesFromString(): Argument #2 ($length) must be greater than or equal to 0