Add regression test for broken non commutative multiplication

Author: Girgias

ext/zend_test/test.c

@@ -611,6 +611,73 @@ static ZEND_METHOD(ZendTestForbidDynamicCall, callStatic)
 	zend_forbid_dynamic_call();
 }
 
+// TODO HERE
+/* ncm refers to non commutative multiplication */
+static zend_class_entry *ncm_ce;
+static zend_object_handlers ncm_object_handlers;
+
+static zend_object* ncm_object_create_ex(zend_class_entry* ce, zend_long l) {
+	zend_object *obj = zend_objects_new(ce);
+	object_properties_init(obj, ce);
+	obj->handlers = &ncm_object_handlers;
+	ZVAL_LONG(OBJ_PROP_NUM(obj, 0), l);
+	return obj;
+}
+static zend_object *ncm_object_create(zend_class_entry *ce) /* {{{ */
+{
+	return ncm_object_create_ex(ce, 0);
+}
+/* }}} */
+
+static inline void ncm_create(zval *target, zend_long l) /* {{{ */
+{
+	ZVAL_OBJ(target, ncm_object_create_ex(ncm_ce, l));
+}
+
+#define IS_NCM(zval) \
+	(Z_TYPE_P(zval) == IS_OBJECT && instanceof_function(Z_OBJCE_P(zval), ncm_ce))
+
+static void ncm_subtraction(zval *result, zval *op1, zval *op2)
+{
+	zend_long val_1;
+	zend_long val_2;
+	if (IS_NCM(op1)) {
+		val_1 = Z_LVAL_P(OBJ_PROP_NUM(Z_OBJ_P(op1), 0));
+	} else {
+		val_1 = zval_get_long(op1);
+	}
+	if (IS_NCM(op2)) {
+		val_2 = Z_LVAL_P(OBJ_PROP_NUM(Z_OBJ_P(op2), 0));
+	} else {
+		val_2 = zval_get_long(op2);
+	}
+
+	ncm_create(result, val_1 - val_2);
+}
+
+static zend_result ncm_do_operation(zend_uchar opcode, zval *result, zval *op1, zval *op2)
+{
+	switch (opcode) {
+	case ZEND_MUL:
+		ncm_subtraction(result, op1, op2);
+		if (UNEXPECTED(EG(exception))) { return FAILURE; }
+		return SUCCESS;
+	default:
+		return FAILURE;
+	}
+}
+
+PHP_METHOD(NonCommutativeMultiplication, __construct)
+{
+	zend_long l;
+
+	ZEND_PARSE_PARAMETERS_START(1, 1)
+		Z_PARAM_LONG(l)
+	ZEND_PARSE_PARAMETERS_END();
+
+	ZVAL_LONG(OBJ_PROP_NUM(Z_OBJ_P(ZEND_THIS), 0), l);
+}
+
 PHP_INI_BEGIN()
 	STD_PHP_INI_BOOLEAN("zend_test.replace_zend_execute_ex", "0", PHP_INI_SYSTEM, OnUpdateBool, replace_zend_execute_ex, zend_zend_test_globals, zend_test_globals)
 	STD_PHP_INI_BOOLEAN("zend_test.register_passes", "0", PHP_INI_SYSTEM, OnUpdateBool, register_passes, zend_zend_test_globals, zend_test_globals)
@@ -713,6 +780,12 @@ PHP_MINIT_FUNCTION(zend_test)
 	zend_test_string_enum = register_class_ZendTestStringEnum();
 	zend_test_int_enum = register_class_ZendTestIntEnum();
 
+	/* Non commutative multiplication class */
+	ncm_ce = register_class_NonCommutativeMultiplication();
+	ncm_ce->create_object = ncm_object_create;
+	memcpy(&ncm_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));
+	ncm_object_handlers.do_operation = ncm_do_operation;
+
 	zend_register_functions(NULL, ext_function_legacy, NULL, EG(current_module)->type);
 
 	// Loading via dl() not supported with the observer API

ext/zend_test/test.stub.php

@@ -98,6 +98,12 @@ enum ZendTestIntEnum: int {
         case Baz = -1;
     }
 
+    final class NonCommutativeMultiplication {
+        private int $val;
+
+        public function __construct(int $val) {}
+    }
+
     function zend_test_array_return(): array {}
 
     function zend_test_nullable_array_return(): ?array {}

ext/zend_test/test_arginfo.h

@@ -0,0 +1,61 @@
+--TEST--
+Zend: test non commutative multiplication object handler
+--EXTENSIONS--
+zend_test
+--XFAIL--
+Broken non commutative multiplication with more than 2 ops
+--FILE--
+<?php
+
+$ten = new NonCommutativeMultiplication(10);
+$fifty = new NonCommutativeMultiplication(50);
+$hundred = new NonCommutativeMultiplication(100);
+
+var_dump($ten);
+var_dump($fifty);
+var_dump($hundred);
+
+/* $hundred * 20 gives a new NCM object, thus final result is 30 = ((100 - 20) - 50) */
+var_dump($hundred * 20 * 50);
+/* Multiplication corresponds to subtraction for this object */
+var_dump(100 - 50 - 10);
+var_dump($hundred * $fifty * $ten);
+var_dump(10 - 50 - 100);
+var_dump($ten * $fifty * $hundred);
+var_dump(50 - 100 - 10);
+var_dump($fifty * $hundred * $ten);
+
+
+?>
+--EXPECT--
+object(NonCommutativeMultiplication)#1 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(10)
+}
+object(NonCommutativeMultiplication)#2 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(50)
+}
+object(NonCommutativeMultiplication)#3 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(100)
+}
+object(NonCommutativeMultiplication)#5 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(30)
+}
+int(40)
+object(NonCommutativeMultiplication)#4 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(40)
+}
+int(-140)
+object(NonCommutativeMultiplication)#5 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(-140)
+}
+int(-60)
+object(NonCommutativeMultiplication)#4 (1) {
+  ["val":"NonCommutativeMultiplication":private]=>
+  int(-60)
+}