Skip to content

Commit 3c68661

Browse files
authored
Minor cleanup in dom_character_data_append_data (#15173)
1 parent ceca599 commit 3c68661

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

ext/dom/characterdata.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,34 +154,30 @@ PHP_METHOD(DOMCharacterData, substringData)
154154
Modern spec URL: https://dom.spec.whatwg.org/#dom-characterdata-appenddata
155155
Since:
156156
*/
157-
static void dom_character_data_append_data(INTERNAL_FUNCTION_PARAMETERS, bool return_true)
157+
static void dom_character_data_append_data(INTERNAL_FUNCTION_PARAMETERS)
158158
{
159-
zval *id;
160159
xmlNode *nodep;
161160
dom_object *intern;
162161
char *arg;
163162
size_t arg_len;
164163

165-
id = ZEND_THIS;
166164
if (zend_parse_parameters(ZEND_NUM_ARGS(), "s", &arg, &arg_len) == FAILURE) {
167165
RETURN_THROWS();
168166
}
169167

170-
DOM_GET_OBJ(nodep, id, xmlNodePtr, intern);
168+
DOM_GET_OBJ(nodep, ZEND_THIS, xmlNodePtr, intern);
171169
xmlTextConcat(nodep, BAD_CAST arg, arg_len);
172-
if (return_true) {
173-
RETURN_TRUE;
174-
}
175170
}
176171

177172
PHP_METHOD(DOMCharacterData, appendData)
178173
{
179-
dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU, true);
174+
dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU);
175+
RETURN_TRUE;
180176
}
181177

182178
PHP_METHOD(Dom_CharacterData, appendData)
183179
{
184-
dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU, false);
180+
dom_character_data_append_data(INTERNAL_FUNCTION_PARAM_PASSTHRU);
185181
}
186182
/* }}} end dom_characterdata_append_data */
187183

0 commit comments

Comments
 (0)