Skip to content

Commit 41e3044

Browse files
authored
Remove obsolete check for missing fclose declaration (#13360)
SunOS 4.1.4 from 1994 didn't have fclose declared in standard header stdio.h. This doesn't need to be checked anymore, as fclose is part of the C89+ standard and declaration is present on Solaris 10 (SunOS 5.10) and later.
1 parent 59211a5 commit 41e3044

File tree

4 files changed

+1
-21
lines changed

4 files changed

+1
-21
lines changed

UPGRADING.INTERNALS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
6161
- Symbol HAVE_JSON has been removed (ext/json is always available since PHP
6262
8.0).
6363
- Symbol DARWIN has been removed (use __APPLE__ to target Darwin systems).
64+
- Symbol MISSING_FCLOSE_DECL and M4 macro PHP_MISSING_FCLOSE_DECL removed.
6465

6566
c. Windows build system changes
6667
- The configure options --with-oci8-11g, --with-oci8-12c, --with-oci8-19 have

build/php.m4

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,22 +1286,6 @@ if test "$ac_cv_struct_flock" = "yes" ; then
12861286
fi
12871287
])
12881288

1289-
dnl
1290-
dnl PHP_MISSING_FCLOSE_DECL
1291-
dnl
1292-
dnl See if we have broken header files like SunOS has.
1293-
dnl
1294-
AC_DEFUN([PHP_MISSING_FCLOSE_DECL],[
1295-
AC_MSG_CHECKING([for fclose declaration])
1296-
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdio.h>]], [[int (*func)() = fclose]])],[
1297-
AC_DEFINE(MISSING_FCLOSE_DECL,0,[ ])
1298-
AC_MSG_RESULT([ok])
1299-
],[
1300-
AC_DEFINE(MISSING_FCLOSE_DECL,1,[ ])
1301-
AC_MSG_RESULT([missing])
1302-
])
1303-
])
1304-
13051289
dnl
13061290
dnl PHP_SOCKADDR_CHECKS
13071291
dnl

configure.ac

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,6 @@ dnl ----------------------------------------------------------------------------
464464
AC_STRUCT_TIMEZONE
465465

466466
PHP_MISSING_TIME_R_DECL
467-
PHP_MISSING_FCLOSE_DECL
468467
PHP_STRUCT_FLOCK
469468

470469
AC_CHECK_TYPES(socklen_t, [], [], [

ext/standard/file.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,6 @@
8686
# include <sys/file.h>
8787
#endif
8888

89-
#if MISSING_FCLOSE_DECL
90-
extern int fclose(FILE *);
91-
#endif
92-
9389
#ifdef HAVE_SYS_MMAN_H
9490
# include <sys/mman.h>
9591
#endif

0 commit comments

Comments
 (0)