Modernization of run-tests.php

Author: dragoonis

run-tests.php

@@ -446,6 +446,7 @@ function main()
                     break;
                 case 'r':
                 case 'l':
+                    // @Dragoonis
                     $test_list = file($argv[++$i]);
                     if ($test_list) {
                         foreach ($test_list as $test) {
@@ -1071,7 +1072,7 @@ function test_sort($a, $b)
 // Send Email to QA Team
 //
 
-function mail_qa_team($data, $status = false)
+function mail_qa_team($data, $status = false): bool
 {
     $url_bits = parse_url(QA_SUBMISSION_PAGE);
 
@@ -1110,7 +1111,7 @@ function mail_qa_team($data, $status = false)
     fwrite($fs, "\r\n\r\n");
     fclose($fs);
 
-    return 1;
+    return true;
 }
 
 //
@@ -1633,15 +1634,15 @@ function run_all_tests_parallel($test_files, $env, $redir_tested)
     }
 }
 
-function send_message($stream, array $message)
+function send_message($stream, array $message): void
 {
     $blocking = stream_get_meta_data($stream)["blocked"];
     stream_set_blocking($stream, true);
     fwrite($stream, base64_encode(serialize($message)) . "\n");
     stream_set_blocking($stream, $blocking);
 }
 
-function kill_children(array $children)
+function kill_children(array $children): void
 {
     foreach ($children as $child) {
         if ($child) {
@@ -1650,7 +1651,7 @@ function kill_children(array $children)
     }
 }
 
-function run_worker($workerID)
+function run_worker($workerID): void
 {
     global $workerSock;