fix #72206 (xml_parser_create/xml_parser_free leaks mem)

krakjoe · krakjoe · commit 4a42fbbbc73a · 2016-05-14T08:11:18.000+01:00
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
@@ -1569,9 +1569,10 @@ PHP_FUNCTION(xml_parser_free)
 		RETURN_FALSE;
 	}
 
-	res = Z_RES(parser->index);
-	ZVAL_UNDEF(&parser->index);
-	zend_list_close(res);
+	if (zend_list_delete(Z_RES(parser->index)) == FAILURE) {
+		RETURN_FALSE;
+	}
+
 	RETURN_TRUE;
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -1569,9 +1569,10 @@ PHP_FUNCTION(xml_parser_free)`
`1569`	`1569`	`RETURN_FALSE;`
`1570`	`1570`	`}`
`1571`	`1571`
`1572`		`- res = Z_RES(parser->index);`
`1573`		`- ZVAL_UNDEF(&parser->index);`
`1574`		`- zend_list_close(res);`
	`1572`	`+ if (zend_list_delete(Z_RES(parser->index)) == FAILURE) {`
	`1573`	`+ RETURN_FALSE;`
	`1574`	`+ }`
	`1575`	`+`
`1575`	`1576`	`RETURN_TRUE;`
`1576`	`1577`	`}`
`1577`	`1578`	`/* }}} */`