Skip to content

Commit 4e6fbb0

Browse files
kocsismatekocsismate
committed
Promote warnings to exceptions in ext/gd
Closes GH-6023
1 parent 22982ee commit 4e6fbb0

33 files changed

+95
-69
lines changed

‎ext/gd/gd.c

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -861,20 +861,20 @@ PHP_FUNCTION(imagecolormatch)
861861
result = gdImageColorMatch(im1, im2);
862862
switch (result) {
863863
case -1:
864-
php_error_docref(NULL, E_WARNING, "Image1 must be TrueColor" );
865-
RETURN_FALSE;
864+
zend_argument_value_error(1, "must be TrueColor");
865+
RETURN_THROWS();
866866
break;
867867
case -2:
868-
php_error_docref(NULL, E_WARNING, "Image2 must be Palette" );
869-
RETURN_FALSE;
868+
zend_argument_value_error(2, "must be Palette");
869+
RETURN_THROWS();
870870
break;
871871
case -3:
872-
php_error_docref(NULL, E_WARNING, "Image1 and Image2 must be the same size" );
873-
RETURN_FALSE;
872+
zend_argument_value_error(2, "must be the same size as argument #1 ($im1)");
873+
RETURN_THROWS();
874874
break;
875875
case -4:
876-
php_error_docref(NULL, E_WARNING, "Image2 must have at least one color" );
877-
RETURN_FALSE;
876+
zend_argument_value_error(2, "must have at least one color");
877+
RETURN_THROWS();
878878
break;
879879
}
880880

@@ -1459,7 +1459,7 @@ gdImagePtr _php_image_create_from_string(zend_string *data, char *tn, gdImagePtr
14591459

14601460
im = (*ioctx_func_p)(io_ctx);
14611461
if (!im) {
1462-
php_error_docref(NULL, E_WARNING, "Passed data is not in '%s' format", tn);
1462+
php_error_docref(NULL, E_WARNING, "Passed data is not in \"%s\" format", tn);
14631463
io_ctx->gd_free(io_ctx);
14641464
return NULL;
14651465
}
@@ -1483,8 +1483,8 @@ PHP_FUNCTION(imagecreatefromstring)
14831483
}
14841484

14851485
if (ZSTR_LEN(data) < sizeof(sig)) {
1486-
php_error_docref(NULL, E_WARNING, "Empty string or invalid image");
1487-
RETURN_FALSE;
1486+
zend_argument_value_error(1, "cannot be empty");
1487+
RETURN_THROWS();
14881488
}
14891489

14901490
memcpy(sig, ZSTR_VAL(data), sizeof(sig));
@@ -1666,7 +1666,7 @@ static void _php_image_create_from(INTERNAL_FUNCTION_PARAMETERS, int image_type,
16661666
return;
16671667
}
16681668

1669-
php_error_docref(NULL, E_WARNING, "'%s' is not a valid %s file", file, tn);
1669+
php_error_docref(NULL, E_WARNING, "\"%s\" is not a valid %s file", file, tn);
16701670
out_err:
16711671
php_stream_close(stream);
16721672
RETURN_FALSE;
@@ -1806,7 +1806,7 @@ static void _php_image_output(INTERNAL_FUNCTION_PARAMETERS, int image_type, char
18061806

18071807
fp = VCWD_FOPEN(fn, "wb");
18081808
if (!fp) {
1809-
php_error_docref(NULL, E_WARNING, "Unable to open '%s' for writing", fn);
1809+
php_error_docref(NULL, E_WARNING, "Unable to open \"%s\" for writing", fn);
18101810
RETURN_FALSE;
18111811
}
18121812

@@ -2297,8 +2297,8 @@ PHP_FUNCTION(imagecolorsforindex)
22972297
add_assoc_long(return_value,"blue", gdImageBlue(im,col));
22982298
add_assoc_long(return_value,"alpha", gdImageAlpha(im,col));
22992299
} else {
2300-
php_error_docref(NULL, E_WARNING, "Color index %d out of range", col);
2301-
RETURN_FALSE;
2300+
zend_argument_value_error(2, "is out of range");
2301+
RETURN_THROWS();
23022302
}
23032303
}
23042304
/* }}} */

‎ext/gd/tests/001-mb.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ echo "Done\n";
2020
Warning: imagecreatefrompng(%s001私はガラスを食べられます.test): Failed to open stream: No such file or directory in %s on line %d
2121
bool(false)
2222

23-
Warning: imagecreatefrompng(): '%s001私はガラスを食べられます.test' is not a valid PNG file in %s on line %d
23+
Warning: imagecreatefrompng(): "%s001私はガラスを食べられます.test" is not a valid PNG file in %s on line %d
2424
bool(false)
2525
Done

‎ext/gd/tests/001.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ echo "Done\n";
2020
Warning: imagecreatefrompng(%s001.test): Failed to open stream: No such file or directory in %s on line %d
2121
bool(false)
2222

23-
Warning: imagecreatefrompng(): '%s001.test' is not a valid PNG file in %s on line %d
23+
Warning: imagecreatefrompng(): "%s001.test" is not a valid PNG file in %s on line %d
2424
bool(false)
2525
Done

‎ext/gd/tests/bug37346-mb.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ Bug #37346 (gdimagecreatefromgif, bad colormap)
99
$im = imagecreatefromgif(__DIR__ . '/bug37346私はガラスを食べられます.gif');
1010
?>
1111
--EXPECTF--
12-
Warning: imagecreatefromgif(): '%sbug37346私はガラスを食べられます.gif' is not a valid GIF file in %sbug37346-mb.php on line %d
12+
Warning: imagecreatefromgif(): "%sbug37346私はガラスを食べられます.gif" is not a valid GIF file in %sbug37346-mb.php on line %d

‎ext/gd/tests/bug37346.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ Bug #37346 (gdimagecreatefromgif, bad colormap)
99
$im = imagecreatefromgif(__DIR__ . '/bug37346.gif');
1010
?>
1111
--EXPECTF--
12-
Warning: imagecreatefromgif(): '%sbug37346.gif' is not a valid GIF file in %sbug37346.php on line %d
12+
Warning: imagecreatefromgif(): "%sbug37346.gif" is not a valid GIF file in %sbug37346.php on line %d

‎ext/gd/tests/bug37360.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ $im = imagecreatefromgif(__DIR__ . '/bug37360.gif');
1010
var_dump($im);
1111
?>
1212
--EXPECTF--
13-
Warning: imagecreatefromgif(): '%s' is not a valid GIF file in %s on line %d
13+
Warning: imagecreatefromgif(): "%s" is not a valid GIF file in %s on line %d
1414
bool(false)

‎ext/gd/tests/bug38112.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ Bug #38112 (GIF Invalid Code size ).
1111
$im = imagecreatefromgif(__DIR__ . '/bug38112.gif');
1212
?>
1313
--EXPECTF--
14-
Warning: imagecreatefromgif(): '%sbug38112.gif' is not a valid GIF file in %sbug38112.php on line %d
14+
Warning: imagecreatefromgif(): "%sbug38112.gif" is not a valid GIF file in %sbug38112.php on line %d

‎ext/gd/tests/bug39780.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ Warning: imagecreatefrompng(): gd-png: fatal libpng error: Read Error: truncate
1616

1717
Warning: imagecreatefrompng(): gd-png error: setjmp returns error condition in %s on line %d
1818

19-
Warning: imagecreatefrompng(): '%s' is not a valid PNG file in %s on line %d
19+
Warning: imagecreatefrompng(): "%s" is not a valid PNG file in %s on line %d
2020
bool(false)

‎ext/gd/tests/bug39780_extern.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ var_dump($im);
1414
--EXPECTF--
1515
gd-png: fatal libpng error: Read Error: truncated data
1616
gd-png error: setjmp returns error condition 2
17-
Warning: imagecreatefrompng(): '%sbug39780.png' is not a valid PNG file in /%s on line %d
17+
Warning: imagecreatefrompng(): v%sbug39780.png" is not a valid PNG file in /%s on line %d
1818
bool(false)

‎ext/gd/tests/bug71912-mb.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ imagecreatefromgd2(__DIR__ . DIRECTORY_SEPARATOR . "invalid_neg_size私はガラ
1111
?>
1212
OK
1313
--EXPECTF--
14-
Warning: imagecreatefromgd2(): '%s%einvalid_neg_size私はガラスを食べられます.gd2' is not a valid GD2 file in %s%ebug71912-mb.php on line %d
14+
Warning: imagecreatefromgd2(): "%s%einvalid_neg_size私はガラスを食べられます.gd2" is not a valid GD2 file in %s%ebug71912-mb.php on line %d
1515
OK

‎ext/gd/tests/bug71912.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ imagecreatefromgd2(__DIR__ . DIRECTORY_SEPARATOR . "invalid_neg_size.gd2");
1414
?>
1515
OK
1616
--EXPECTF--
17-
Warning: imagecreatefromgd2(): '%s%einvalid_neg_size.gd2' is not a valid GD2 file in %s%ebug71912.php on line %d
17+
Warning: imagecreatefromgd2(): "%s%einvalid_neg_size.gd2" is not a valid GD2 file in %s%ebug71912.php on line %d
1818
OK

‎ext/gd/tests/bug72339.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ unlink($fname);
3535
Warning: imagecreatefromgd2(): Product of memory allocation multiplication would exceed INT_MAX, failing operation gracefully
3636
in %sbug72339.php on line %d
3737

38-
Warning: imagecreatefromgd2(): '%sbug72339.gd' is not a valid GD2 file in %sbug72339.php on line %d
38+
Warning: imagecreatefromgd2(): "%sbug72339.gd" is not a valid GD2 file in %sbug72339.php on line %d

‎ext/gd/tests/bug73161.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ $im = imagecreatefromgd2(__DIR__ . DIRECTORY_SEPARATOR . 'bug73161.gd2');
1212
var_dump($im);
1313
?>
1414
--EXPECTF--
15-
Warning: imagecreatefromgd2(): '%s' is not a valid GD2 file in %s on line %d
15+
Warning: imagecreatefromgd2(): "%s" is not a valid GD2 file in %s on line %d
1616
bool(false)

‎ext/gd/tests/bug73868.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ var_dump(imagecreatefromgd2(__DIR__ . DIRECTORY_SEPARATOR . 'bug73868.gd2'));
1212
Warning: imagecreatefromgd2(): gd2: EOF while reading
1313
in %s on line %d
1414

15-
Warning: imagecreatefromgd2(): '%s' is not a valid GD2 file in %s on line %d
15+
Warning: imagecreatefromgd2(): "%s" is not a valid GD2 file in %s on line %d
1616
bool(false)

‎ext/gd/tests/bug73869.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ var_dump(imagecreatefromgd2(__DIR__ . DIRECTORY_SEPARATOR . 'bug73869a.gd2'));
1010
var_dump(imagecreatefromgd2(__DIR__ . DIRECTORY_SEPARATOR . 'bug73869b.gd2'));
1111
?>
1212
--EXPECTF--
13-
Warning: imagecreatefromgd2(): '%s' is not a valid GD2 file in %s on line %d
13+
Warning: imagecreatefromgd2(): "%s" is not a valid GD2 file in %s on line %d
1414
bool(false)
1515

16-
Warning: imagecreatefromgd2(): '%s' is not a valid GD2 file in %s on line %d
16+
Warning: imagecreatefromgd2(): "%s" is not a valid GD2 file in %s on line %d
1717
bool(false)

‎ext/gd/tests/bug75111.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $str .= hex2bin("01001800000000000000000000000000000000000000000000000000");
1717
var_dump(imagecreatefromstring($str));
1818
?>
1919
--EXPECTF--
20-
Warning: imagecreatefromstring(): Passed data is not in 'BMP' format in %s on line %d
20+
Warning: imagecreatefromstring(): Passed data is not in "BMP" format in %s on line %d
2121

2222
Warning: imagecreatefromstring(): Couldn't create GD Image Stream out of Data in %s on line %d
2323
bool(false)

‎ext/gd/tests/bug75571.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ if (!extension_loaded('gd')) die('skip gd extension not available');
99
var_dump(imagecreatefromgif(__DIR__ . '/bug75571.gif'));
1010
?>
1111
--EXPECTF--
12-
Warning: imagecreatefromgif(): '%s' is not a valid GIF file in %s on line %d
12+
Warning: imagecreatefromgif(): "%s" is not a valid GIF file in %s on line %d
1313
bool(false)

‎ext/gd/tests/bug77195.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ imagecreatefromjpeg($filename);
1414
--EXPECTF--
1515
Warning: imagecreatefromjpeg(): gd-jpeg: JPEG library reports unrecoverable error: JPEG datastream contains no image in %s on line %d
1616

17-
Warning: imagecreatefromjpeg(): '%s' is not a valid JPEG file in %s on line %d
17+
Warning: imagecreatefromjpeg(): "%s" is not a valid JPEG file in %s on line %d

‎ext/gd/tests/bug77973.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var_dump($im);
1616
--EXPECTF--
1717
Warning: imagecreatefromxbm(): Invalid XBM in %s on line %d
1818

19-
Warning: imagecreatefromxbm(): '%s' is not a valid XBM file in %s on line %d
19+
Warning: imagecreatefromxbm(): "%s" is not a valid XBM file in %s on line %d
2020
bool(false)
2121
--CLEAN--
2222
<?php

‎ext/gd/tests/colorclosest.phpt

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ imagedestroy($im);
1414

1515
$im = imagecreate(5,5);
1616
$c = imagecolorclosest($im, 255,0,255);
17-
print_r(imagecolorsforindex($im, $c));
17+
try {
18+
imagecolorsforindex($im, $c);
19+
} catch (ValueError $exception) {
20+
echo $exception->getMessage() . "\n";
21+
}
1822
imagedestroy($im);
1923

2024
$im = imagecreate(5,5);
@@ -48,7 +52,11 @@ imagedestroy($im);
4852

4953
$im = imagecreate(5,5);
5054
$c = imagecolorclosestalpha($im, 255,0,255,100);
51-
print_r(imagecolorsforindex($im, $c));
55+
try {
56+
imagecolorsforindex($im, $c);
57+
} catch (ValueError $exception) {
58+
echo $exception->getMessage() . "\n";
59+
}
5260
imagedestroy($im);
5361

5462
$im = imagecreate(5,5);
@@ -62,7 +70,6 @@ for ($i=0; $i<255; $i++) imagecolorresolvealpha($im, $i,0,0,1);
6270
$c = imagecolorclosestalpha($im, 255,0,0,1);
6371
print_r(imagecolorsforindex($im, $c));
6472

65-
6673
$im = imagecreate(5,5);
6774
for ($i=0; $i<256; $i++) {
6875
if ($i == 246) {
@@ -74,12 +81,10 @@ for ($i=0; $i<256; $i++) {
7481
$c = imagecolorclosestalpha($im, 255,10,10,1);
7582
print_r(imagecolorsforindex($im, $c));
7683

77-
7884
?>
79-
--EXPECTF--
85+
--EXPECT--
8086
FF00FF
81-
82-
Warning: imagecolorsforindex(): Color index -1 out of range in %s on line %d
87+
imagecolorsforindex(): Argument #2 ($index) is out of range
8388
Array
8489
(
8590
[red] => 255
@@ -102,8 +107,7 @@ Array
102107
[alpha] => 0
103108
)
104109
64FF00FF
105-
106-
Warning: imagecolorsforindex(): Color index -1 out of range in %s on line %d
110+
imagecolorsforindex(): Argument #2 ($index) is out of range
107111
Array
108112
(
109113
[red] => 255

‎ext/gd/tests/colormatch.phpt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,16 @@ imagecolormatch
1010
$im = imagecreatetruecolor(5,5);
1111
$im2 = imagecreate(5,5);
1212

13-
imagecolormatch($im, $im2);
13+
try {
14+
imagecolormatch($im, $im2);
15+
} catch (ValueError $exception) {
16+
echo $exception->getMessage() . "\n";
17+
}
1418

1519
echo "ok\n";
1620

1721
imagedestroy($im);
1822
?>
19-
--EXPECTF--
20-
Warning: imagecolormatch(): Image2 must have at least one color in %s on line %d
23+
--EXPECT--
24+
imagecolormatch(): Argument #2 ($im2) must have at least one color
2125
ok

‎ext/gd/tests/crafted_gd2.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ Test max colors for a gd image.
1111
imagecreatefromgd(__DIR__ . '/crafted.gd2');
1212
?>
1313
--EXPECTF--
14-
Warning: imagecreatefromgd(): '%scrafted.gd2' is not a valid GD file in %s on line %d
14+
Warning: imagecreatefromgd(): "%scrafted.gd2" is not a valid GD file in %s on line %d

‎ext/gd/tests/createfromstring.phpt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,17 @@ unlink($dir . '/p.png');
5151

5252

5353
//empty string
54-
$im = imagecreatefromstring('');
54+
try {
55+
imagecreatefromstring('');
56+
} catch (ValueError $exception) {
57+
echo $exception->getMessage() . "\n";
58+
}
5559
//random string > 12
5660
$im = imagecreatefromstring(' asdf jklp foo');
5761
?>
5862
--EXPECTF--
5963
createfromstring truecolor png: ok
6064
createfromstring palette png: ok
61-
62-
Warning: imagecreatefromstring(): Empty string or invalid image in %screatefromstring.php on line %d
65+
imagecreatefromstring(): Argument #1 ($image) cannot be empty
6366

6467
Warning: imagecreatefromstring(): Data is not in a recognized format in %screatefromstring.php on line %d

‎ext/gd/tests/createfromwbmp2.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ unlink($filename);
4545
Warning: imagecreatefromwbmp(): Product of memory allocation multiplication would exceed INT_MAX, failing operation gracefully
4646
in %s on line %d
4747

48-
Warning: imagecreatefromwbmp(): '%s' is not a valid WBMP file in %s on line %d
48+
Warning: imagecreatefromwbmp(): "%s" is not a valid WBMP file in %s on line %d

‎ext/gd/tests/createfromwbmp2_extern.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ unlink($filename);
4444
--EXPECTF--
4545
gd warning: Product of memory allocation multiplication would exceed INT_MAX, failing operation gracefully
4646

47-
Warning: imagecreatefromwbmp(): '%s_tmp.wbmp' is not a valid WBMP file in %s on line %d
47+
Warning: imagecreatefromwbmp(): "%s_tmp.wbmp" is not a valid WBMP file in %s on line %d

‎ext/gd/tests/imagecolormatch_error2.phpt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,13 @@ $ima = imagecreate(110, 20);
1313
$background_color = imagecolorallocate($ima, 0, 0, 0);
1414
$imb = imagecreate(110, 20);
1515
$background_color = imagecolorallocate($imb, 0, 0, 100);
16-
var_dump(imagecolormatch($ima, $imb));
16+
17+
try {
18+
imagecolormatch($ima, $imb);
19+
} catch (ValueError $exception) {
20+
echo $exception->getMessage() . "\n";
21+
}
22+
1723
?>
18-
--EXPECTF--
19-
Warning: imagecolormatch(): Image1 must be TrueColor in %s on line %d
20-
bool(false)
24+
--EXPECT--
25+
imagecolormatch(): Argument #1 ($im1) must be TrueColor

‎ext/gd/tests/imagecolormatch_error3.phpt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,13 @@ $ima = imagecreatetruecolor(110, 20);
1313
$background_color = imagecolorallocate($ima, 0, 0, 0);
1414
$imb = imagecreatetruecolor(110, 20);
1515
$background_color = imagecolorallocate($imb, 0, 0, 100);
16-
var_dump(imagecolormatch($ima, $imb));
16+
17+
try {
18+
imagecolormatch($ima, $imb);
19+
} catch (ValueError $exception) {
20+
echo $exception->getMessage() . "\n";
21+
}
22+
1723
?>
18-
--EXPECTF--
19-
Warning: imagecolormatch(): Image2 must be Palette in %s on line %d
20-
bool(false)
24+
--EXPECT--
25+
imagecolormatch(): Argument #2 ($im2) must be Palette

‎ext/gd/tests/imagecolormatch_error4.phpt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,13 @@ $ima = imagecreatetruecolor(110, 20);
1313
$background_color = imagecolorallocate($ima, 0, 0, 0);
1414
$imb = imagecreate(100, 20);
1515
$background_color = imagecolorallocate($imb, 0, 0, 100);
16-
var_dump(imagecolormatch($ima, $imb));
16+
17+
try {
18+
imagecolormatch($ima, $imb);
19+
} catch (ValueError $exception) {
20+
echo $exception->getMessage() . "\n";
21+
}
22+
1723
?>
18-
--EXPECTF--
19-
Warning: imagecolormatch(): Image1 and Image2 must be the same size in %s on line %d
20-
bool(false)
24+
--EXPECT--
25+
imagecolormatch(): Argument #2 ($im2) must be the same size as argument #1 ($im1)

‎ext/gd/tests/libgd00086.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ Warning: imagecreatefrompng(): gd-png: fatal libpng error: Read Error: truncate
1616

1717
Warning: imagecreatefrompng(): gd-png error: setjmp returns error condition in %s on line %d
1818

19-
Warning: imagecreatefrompng(): '%s' is not a valid PNG file in %s on line %d
19+
Warning: imagecreatefrompng(): "%s" is not a valid PNG file in %s on line %d
2020
bool(false)

‎ext/gd/tests/libgd00086_extern.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ var_dump($im);
1515
gd-png: fatal libpng error: Read Error: truncated data
1616
gd-png error: setjmp returns error condition 1
1717

18-
Warning: imagecreatefrompng(): '%slibgd00086.png' is not a valid PNG file in %s on line %d
18+
Warning: imagecreatefrompng(): "%slibgd00086.png" is not a valid PNG file in %s on line %d
1919
bool(false)

0 commit comments

Comments
 (0)