Declare tentative return types for ext/spl - part 1

Author: kocsismate

Zend/tests/foreach_004.phpt

@@ -16,10 +16,10 @@ class IT extends ArrayIterator {
         }
     }
 
-    function rewind()  {$this->trap(__FUNCTION__); return parent::rewind();}
-    function valid()   {$this->trap(__FUNCTION__); return parent::valid();}
-    function key()     {$this->trap(__FUNCTION__); return parent::key();}
-    function next()    {$this->trap(__FUNCTION__); return parent::next();}
+    function rewind(): void  {$this->trap(__FUNCTION__); parent::rewind();}
+    function valid(): bool   {$this->trap(__FUNCTION__); return parent::valid();}
+    function key(): mixed    {$this->trap(__FUNCTION__); return parent::key();}
+    function next(): void    {$this->trap(__FUNCTION__); parent::next();}
 }
 
 foreach(['rewind', 'valid', 'key', 'next'] as $trap) {

Zend/tests/iterator_key_by_ref.phpt

@@ -3,6 +3,7 @@ Iterator::key() with by-ref return
 --FILE--
 <?php
 class Test extends ArrayIterator {
+    #[ReturnTypeWillChange]
     function &key() {
         return $foo;
     }

ext/phar/tests/phar_oo_004.phpt

@@ -33,31 +33,31 @@ class MyDirectoryIterator extends DirectoryIterator
         parent::__construct($dir);
     }
 
-    function rewind()
+    function rewind(): void
     {
         echo __METHOD__ . "\n";
         parent::rewind();
     }
 
-    function valid()
+    function valid(): bool
     {
         echo __METHOD__ . "\n";
         return parent::valid();
     }
 
-    function key()
+    function key(): mixed
     {
         echo __METHOD__ . "\n";
         return parent::key();
     }
 
-    function current()
+    function current(): mixed
     {
         echo __METHOD__ . "\n";
         return parent::current();
     }
 
-    function next()
+    function next(): void
     {
         echo __METHOD__ . "\n";
         parent::next();

ext/phar/tests/phar_oo_008.phpt

@@ -31,7 +31,7 @@ foreach($f as $k => $v)
 
 class MyCSVFile extends SplFileObject
 {
-    function current()
+    function current(): string|array|false
     {
         return parent::fgetcsv(',', '"');
     }
@@ -62,10 +62,10 @@ foreach($v as $k => $d)
 
 class MyCSVFile2 extends SplFileObject
 {
-    function getCurrentLine()
+    function getCurrentLine(): string
     {
         echo __METHOD__ . "\n";
-        return parent::fgetcsv(',', '"');
+        return (string) parent::fgetcsv(',', '"');
     }
 }