Simpler code suggestions

SakiTakamachi · nielsdos · web-flow · commit 56a90280e604 · 2025-03-13T11:16:20.000+09:00
Co-authored-by: Niels Dossche &lt;7771979+nielsdos@users.noreply.github.com&gt;
diff --git a/ext/bcmath/libbcmath/src/div.c b/ext/bcmath/libbcmath/src/div.c
@@ -317,12 +317,8 @@ static inline void bc_divide_by_pow_10(
 	const char *numeratorptr, size_t numerator_readable_size, bc_num *quot, size_t quot_size, size_t quot_scale)
 {
 	char *qptr = (*quot)->n_value;
-	if (quot_size <= quot_scale) {
-		/* int is 0 */
+	for (size_t i = quot_size; i <= quot_scale; i++) {
 		*qptr++ = 0;
-		for (size_t i = quot_size; i < quot_scale; i++) {
-			*qptr++ = 0;
-		}
 	}
 
 	size_t numerator_use_size = quot_size > numerator_readable_size ? numerator_readable_size : quot_size;

Original file line number	Diff line number	Diff line change
`@@ -317,12 +317,8 @@ static inline void bc_divide_by_pow_10(`
`317`	`317`	`const char numeratorptr, size_t numerator_readable_size, bc_num quot, size_t quot_size, size_t quot_scale)`
`318`	`318`	`{`
`319`	`319`	`char qptr = (quot)->n_value;`
`320`		`- if (quot_size <= quot_scale) {`
`321`		`- /* int is 0 */`
	`320`	`+ for (size_t i = quot_size; i <= quot_scale; i++) {`
`322`	`321`	`*qptr++ = 0;`
`323`		`- for (size_t i = quot_size; i < quot_scale; i++) {`
`324`		`- *qptr++ = 0;`
`325`		`- }`
`326`	`322`	`}`
`327`	`323`
`328`	`324`	`size_t numerator_use_size = quot_size > numerator_readable_size ? numerator_readable_size : quot_size;`