Fix leak in openssl_cms_read()

nikic · nikic · commit 57e17e58a58d · 2020-06-08T10:13:25.000+02:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -5789,6 +5789,12 @@ PHP_FUNCTION(openssl_cms_read)
 	if (cms != NULL) {
 		CMS_ContentInfo_free(cms);
 	}
+	if (certs != NULL) {
+		sk_X509_pop_free(certs, X509_free);
+	}
+	if (crls != NULL) {
+		sk_X509_CRL_pop_free(crls, X509_CRL_free);
+	}
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -5789,6 +5789,12 @@ PHP_FUNCTION(openssl_cms_read)`
`5789`	`5789`	`if (cms != NULL) {`
`5790`	`5790`	`CMS_ContentInfo_free(cms);`
`5791`	`5791`	`}`
	`5792`	`+ if (certs != NULL) {`
	`5793`	`+ sk_X509_pop_free(certs, X509_free);`
	`5794`	`+ }`
	`5795`	`+ if (crls != NULL) {`
	`5796`	`+ sk_X509_CRL_pop_free(crls, X509_CRL_free);`
	`5797`	`+ }`
`5792`	`5798`	`}`
`5793`	`5799`	`/* }}} */`
`5794`	`5800`