Skip to content

Commit 585f71f

Browse files
committed
Fix some errors in mysqlnd charset list
I fixed the stuff that seemed obviously wrong, but there are some more differences with the SHOW COLLATIONS output: * The whole range of "utf16" collations missing * "filename" missing * "ucs2_general_mysql500_ci" and "utf8_general_mysql500_ci" missing I wasn't sure whether those omissions are intentional, so I didn't add them.
1 parent ec7250f commit 585f71f

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

ext/mysqlnd/mysqlnd_charset.c

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -445,12 +445,12 @@ mysqlnd_mbcharlen_utf32(unsigned int utf32 __attribute((unused)))
445445
const MYSQLND_CHARSET mysqlnd_charsets[] =
446446
{
447447
{ 1, "big5","big5_chinese_ci", 1, 2, "", mysqlnd_mbcharlen_big5, check_mb_big5},
448-
{ 3, "dec8", "dec8_swedisch_ci", 1, 1, "", NULL, NULL},
448+
{ 3, "dec8", "dec8_swedish_ci", 1, 1, "", NULL, NULL},
449449
{ 4, "cp850", "cp850_general_ci", 1, 1, "", NULL, NULL},
450450
{ 6, "hp8", "hp8_english_ci", 1, 1, "", NULL, NULL},
451451
{ 7, "koi8r", "koi8r_general_ci", 1, 1, "", NULL, NULL},
452452
{ 8, "latin1", "latin1_swedish_ci", 1, 1, "", NULL, NULL},
453-
{ 5, "latin1", "latin1_german_ci", 1, 1, "", NULL, NULL}, /* should be after 0x9 because swedish_ci is the default collation */
453+
{ 5, "latin1", "latin1_german1_ci", 1, 1, "", NULL, NULL}, /* should be after 0x8 because swedish_ci is the default collation */
454454
{ 9, "latin2", "latin2_general_ci", 1, 1, "", NULL, NULL},
455455
{ 2, "latin2", "latin2_czech_cs", 1, 1, "", NULL, NULL}, /* should be after 0x9 because general_ci is the default collation */
456456
{ 10, "swe7", "swe7_swedish_ci", 1, 1, "", NULL, NULL},
@@ -485,7 +485,7 @@ const MYSQLND_CHARSET mysqlnd_charsets[] =
485485
{ 59, "cp1257", "cp1257_general_ci", 1, 1, "", NULL, NULL},
486486
{ 63, "binary", "binary", 1, 1, "", NULL, NULL},
487487
{ 97, "eucjpms", "eucjpms_japanese_ci", 1, 3, "", mysqlnd_mbcharlen_eucjpms, check_mb_eucjpms},
488-
{ 29, "cp1257", "cp1257_lithunian_ci", 1, 1, "", NULL, NULL},
488+
{ 29, "cp1257", "cp1257_lithuanian_ci", 1, 1, "", NULL, NULL},
489489
{ 31, "latin1", "latin1_german2_ci", 1, 1, "", NULL, NULL},
490490
{ 34, "cp1250", "cp1250_czech_cs", 1, 1, "", NULL, NULL},
491491
{ 42, "latin7", "latin7_general_cs", 1, 1, "", NULL, NULL},
@@ -506,19 +506,17 @@ const MYSQLND_CHARSET mysqlnd_charsets[] =
506506
{ 55, "utf16", "utf16_bin", 2, 4, "UTF-16 Unicode", mysqlnd_mbcharlen_utf16, check_mb_utf16},
507507
{ 56, "utf16le", "utf16le_general_ci", 2, 4, "UTF-16LE Unicode", mysqlnd_mbcharlen_utf16, check_mb_utf16},
508508
{ 58, "cp1257", "cp1257_bin", 1, 1, "", NULL, NULL},
509-
#ifdef USED_TO_BE_SO_BEFORE_MYSQL_5_5
510-
{ 60, "armascii8", "armascii8_bin", 1, 1, "", NULL, NULL},
511-
#endif
512509
/*55*/{ 60, "utf32", "utf32_general_ci", 4, 4, "UTF-32 Unicode", mysqlnd_mbcharlen_utf32, check_mb_utf32},
513510
/*55*/{ 61, "utf32", "utf32_bin", 4, 4, "UTF-32 Unicode", mysqlnd_mbcharlen_utf32, check_mb_utf32},
514511
{ 62, "utf16le", "utf16le_bin", 2, 4, "UTF-16LE Unicode", mysqlnd_mbcharlen_utf16, check_mb_utf16},
512+
{ 64, "armscii8", "armscii8_bin", 1, 1, "", NULL, NULL},
515513
{ 65, "ascii", "ascii_bin", 1, 1, "", NULL, NULL},
516514
{ 66, "cp1250", "cp1250_bin", 1, 1, "", NULL, NULL},
517515
{ 67, "cp1256", "cp1256_bin", 1, 1, "", NULL, NULL},
518516
{ 68, "cp866", "cp866_bin", 1, 1, "", NULL, NULL},
519517
{ 69, "dec8", "dec8_bin", 1, 1, "", NULL, NULL},
520518
{ 70, "greek", "greek_bin", 1, 1, "", NULL, NULL},
521-
{ 71, "hebew", "hebrew_bin", 1, 1, "", NULL, NULL},
519+
{ 71, "hebrew", "hebrew_bin", 1, 1, "", NULL, NULL},
522520
{ 72, "hp8", "hp8_bin", 1, 1, "", NULL, NULL},
523521
{ 73, "keybcs2", "keybcs2_bin", 1, 1, "", NULL, NULL},
524522
{ 74, "koi8r", "koi8r_bin", 1, 1, "", NULL, NULL},
@@ -558,7 +556,7 @@ const MYSQLND_CHARSET mysqlnd_charsets[] =
558556
{ 137, "ucs2", "ucs2_turkish_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
559557
{ 138, "ucs2", "ucs2_czech_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
560558
{ 139, "ucs2", "ucs2_danish_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
561-
{ 140, "ucs2", "ucs2_lithunian_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
559+
{ 140, "ucs2", "ucs2_lithuanian_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
562560
{ 141, "ucs2", "ucs2_slovak_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
563561
{ 142, "ucs2", "ucs2_spanish2_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
564562
{ 143, "ucs2", "ucs2_roman_ci", 2, 2, "", mysqlnd_mbcharlen_ucs2, check_mb_ucs2},
@@ -596,7 +594,7 @@ const MYSQLND_CHARSET mysqlnd_charsets[] =
596594
/*56*/{182, "utf32", "utf32_unicode_520_ci", 4, 4, "UTF-32 Unicode", mysqlnd_mbcharlen_utf32, check_mb_utf32},
597595
/*56*/{183, "utf32", "utf32_vietnamese_ci", 4, 4, "UTF-32 Unicode", mysqlnd_mbcharlen_utf32, check_mb_utf32},
598596

599-
{ 192, UTF8_MB3, UTF8_MB3"_general_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
597+
{ 192, UTF8_MB3, UTF8_MB3"_unicode_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
600598
{ 193, UTF8_MB3, UTF8_MB3"_icelandic_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
601599
{ 194, UTF8_MB3, UTF8_MB3"_latvian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
602600
{ 195, UTF8_MB3, UTF8_MB3"_romanian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
@@ -608,15 +606,15 @@ const MYSQLND_CHARSET mysqlnd_charsets[] =
608606
{ 201, UTF8_MB3, UTF8_MB3"_turkish_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
609607
{ 202, UTF8_MB3, UTF8_MB3"_czech_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
610608
{ 203, UTF8_MB3, UTF8_MB3"_danish_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid },
611-
{ 204, UTF8_MB3, UTF8_MB3"_lithunian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid },
609+
{ 204, UTF8_MB3, UTF8_MB3"_lithuanian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid },
612610
{ 205, UTF8_MB3, UTF8_MB3"_slovak_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
613611
{ 206, UTF8_MB3, UTF8_MB3"_spanish2_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
614612
{ 207, UTF8_MB3, UTF8_MB3"_roman_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
615613
{ 208, UTF8_MB3, UTF8_MB3"_persian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
616614
{ 209, UTF8_MB3, UTF8_MB3"_esperanto_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
617615
{ 210, UTF8_MB3, UTF8_MB3"_hungarian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
618616
{ 211, UTF8_MB3, UTF8_MB3"_sinhala_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
619-
{ 211, UTF8_MB3, UTF8_MB3"_german2_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
617+
{ 212, UTF8_MB3, UTF8_MB3"_german2_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
620618
{ 213, UTF8_MB3, UTF8_MB3"_croatian_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
621619
{ 214, UTF8_MB3, UTF8_MB3"_unicode_520_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},
622620
{ 215, UTF8_MB3, UTF8_MB3"_vietnamese_ci", 1, 3, "", mysqlnd_mbcharlen_utf8mb3, check_mb_utf8mb3_valid},

0 commit comments

Comments
 (0)