Fix GH-15028: Memory leak in ext/phar/stream.c

nielsdos · nielsdos · commit 5996227f8824 · 2024-07-19T14:58:28.000+02:00
Closes GH-15029.
diff --git a/NEWS b/NEWS
@@ -14,6 +14,9 @@ PHP                                                                        NEWS
 - Soap:
   . Fixed bug #55639 (Digest autentication dont work). (nielsdos)
 
+- Streams:
+  . Fixed bug GH-15028 (Memory leak in ext/phar/stream.c). (nielsdos)
+
 01 Aug 2024, PHP 8.2.22
 
 - Core:
diff --git a/ext/phar/stream.c b/ext/phar/stream.c
@@ -782,6 +782,7 @@ static int phar_wrapper_rename(php_stream_wrapper *wrapper, const char *url_from
 	}
 	if (PHAR_G(readonly) && (!pto || !pto->is_data)) {
 		php_url_free(resource_from);
+		php_url_free(resource_to);
 		php_error_docref(NULL, E_WARNING, "phar error: Write operations disabled by the php.ini setting phar.readonly");
 		return 0;
 	}

Original file line number	Diff line number	Diff line change
`@@ -782,6 +782,7 @@ static int phar_wrapper_rename(php_stream_wrapper wrapper, const char url_from`
`782`	`782`	`}`
`783`	`783`	`if (PHAR_G(readonly) && (!pto \|\| !pto->is_data)) {`
`784`	`784`	`php_url_free(resource_from);`
	`785`	`+ php_url_free(resource_to);`
`785`	`786`	`php_error_docref(NULL, E_WARNING, "phar error: Write operations disabled by the php.ini setting phar.readonly");`
`786`	`787`	`return 0;`
`787`	`788`	`}`