remove PDO::pgsqlSetNoticeCallback()

Keep only PdoPgsql::setNoticeCallback()

Author: outtersg

ext/pdo_pgsql/pgsql_driver.stub.php

@@ -37,8 +37,4 @@ public function pgsqlGetPid(): int {}
     /* Do NOT add new methods here. See https://wiki.php.net/rfc/pdo_driver_specific_subclasses
      * Any new feature should be declared only on PdoPgsql.
      */
-#if 1
-    /** @implementation-alias PdoPgsql::setNoticeCallback */
-    public function pgsqlSetNoticeCallback(?callable $callback): void {}
-#endif
 }

ext/pdo_pgsql/pgsql_driver_arginfo.h

@@ -2,7 +2,7 @@
 require_once dirname(__FILE__) . '/../../../ext/pdo/tests/pdo_test.inc';
 require_once dirname(__FILE__) . '/config.inc';
 if (!isset($db)) {
-$db = PDOTest::test_factory(dirname(__FILE__) . '/common.phpt');
+$db = new PdoPgsql($config['ENV']['PDOTEST_DSN']);
 }
 if (!isset($rounds) || empty($rounds)) {
     $rounds = [ null, 'Re' ];
@@ -25,7 +25,7 @@ echo "Caught TypeError: ".$err->getMessage()."\n";
 $db->exec("delete from t");
 $db->exec("insert into t values ('ah')");
 }
-$db->pgsqlSetNoticeCallback(null);
+$db->setNoticeCallback(null);
 $db->exec("delete from t");
 $db->exec("insert into t values ('ah')");
 var_dump($db->query("select * from t")->fetchAll(PDO::FETCH_ASSOC));

ext/pdo_pgsql/tests/issue78621.inc

@@ -1,5 +1,5 @@
 --TEST--
-pgsqlSetNoticeCallback catches Postgres "raise notice".
+PdoPgsql::setNoticeCallback catches Postgres "raise notice".
 --SKIPIF--
 <?php
 if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded');
@@ -13,7 +13,7 @@ function disp($message) { echo trim($message)."\n"; }
 function dispRe($message) { echo "Re".trim($message)."\n"; }
 function attach($db, $prefix = '')
 {
-    $db->pgsqlSetNoticeCallback('disp'.$prefix);
+    $db->setNoticeCallback('disp'.$prefix);
 }
 require dirname(__FILE__) . '/issue78621.inc';
 ?>

ext/pdo_pgsql/tests/issue78621.phpt

@@ -1,5 +1,5 @@
 --TEST--
-pgsqlSetNoticeCallback catches Postgres "raise notice".
+PdoPgsql::setNoticeCallback catches Postgres "raise notice".
 --SKIPIF--
 <?php
 if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded');
@@ -16,13 +16,13 @@ function attach($db, $prefix = '')
     switch($flavor)
     {
         case 0:
-            $db->pgsqlSetNoticeCallback(function($message) use($prefix) { echo $prefix.trim($message)."\n"; });
+            $db->setNoticeCallback(function($message) use($prefix) { echo $prefix.trim($message)."\n"; });
             // https://github.com/php/php-src/pull/4823#pullrequestreview-335623806
             $eraseCallbackMemoryHere = (object)[1];
             break;
         case 1:
             $closure = function($message) use($prefix) { echo $prefix.'('.get_class($this).')'.trim($message)."\n"; };
-            $db->pgsqlSetNoticeCallback($closure->bindTo(new \stdClass));
+            $db->setNoticeCallback($closure->bindTo(new \stdClass));
             break;
     }
 }

ext/pdo_pgsql/tests/issue78621_closure.phpt

@@ -1,5 +1,5 @@
 --TEST--
-pgsqlSetNoticeCallback catches Postgres "raise notice".
+PdoPgsql::setNoticeCallback catches Postgres "raise notice".
 --SKIPIF--
 <?php
 if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded');
@@ -27,8 +27,8 @@ function attach($db, $prefix = '')
     global $flavor;
     switch($flavor)
     {
-        case 0: $db->pgsqlSetNoticeCallback([ $logger, 'disp'.$prefix ]); break;
-        case 1: $db->pgsqlSetNoticeCallback([ $logger, 'whatever'.$prefix ]); break;
+        case 0: $db->setNoticeCallback([ $logger, 'disp'.$prefix ]); break;
+        case 1: $db->setNoticeCallback([ $logger, 'whatever'.$prefix ]); break;
     }
 }
 echo "Testing with method explicitely plugged:\n";