Fix memory leak caused by attribute validation and add test for class method deprecations.

Author: beberlei

Zend/tests/attributes/deprecated_001.phpt

@@ -14,12 +14,34 @@ function test() {
 function test2() {
 }
 
+class Clazz {
+    #[Deprecated]
+    function test() {
+    }
+
+    #[Deprecated("use test() instead")]
+    function test2() {
+    }
+}
+
 test();
 test2();
 call_user_func("test");
+
+$cls = new Clazz();
+$cls->test();
+$cls->test2();
+
+call_user_func([$cls, "test"]);
 --EXPECTF--
 Deprecated: Function test() is deprecated in %s
 
 Deprecated: Function test2() is deprecated, use test() instead in %s
 
 Deprecated: Function test() is deprecated in %s
+
+Deprecated: Method Clazz::test() is deprecated in %s
+
+Deprecated: Method Clazz::test2() is deprecated, use test() instead in %s
+
+Deprecated: Method Clazz::test() is deprecated in %s

Zend/tests/attributes/deprecated_003.phpt

@@ -0,0 +1,12 @@
+--TEST--
+#[Deprecated] attribute with wrong type
+--FILE--
+<?php
+
+#[Deprecated(1234)]
+function test() {
+}
+
+
+--EXPECTF--
+Fatal error: Deprecated::__construct: Argument #1 ($message) must be of type string, int given in %s

Zend/zend_attributes.c

@@ -70,11 +70,15 @@ void validate_deprecated_attribute(zend_attribute *attr, uint32_t target, zend_c
 		}
 
 		if (Z_TYPE(message) != IS_STRING) {
+			zval_ptr_dtor(&message);
+
 			zend_error_noreturn(E_COMPILE_ERROR,
 				"Deprecated::__construct: Argument #1 ($message) must be of type string, %s given",
 				zend_zval_type_name(&message)
 			);
 		}
+
+		zval_ptr_dtor(&message);
 	}
 }
 

Zend/zend_execute.c

@@ -1518,6 +1518,8 @@ ZEND_API ZEND_COLD void ZEND_FASTCALL zend_deprecated_function(const zend_functi
 				ZSTR_VAL(message_suffix)
 			);
 		}
+
+		zend_string_release(message_suffix);
 	} else {
 		if (fbc->common.scope) {
 			zend_error(E_DEPRECATED, "Method %s::%s() is deprecated",