Skip to content

Commit 6c0eb1b

Browse files
committed
Promote warnings to errors in assert_options()
1 parent dd10e70 commit 6c0eb1b

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

ext/standard/assert.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,10 @@ PHP_FUNCTION(assert_options)
316316
break;
317317

318318
default:
319-
php_error_docref(NULL, E_WARNING, "Unknown value " ZEND_LONG_FMT, what);
319+
zend_throw_error(NULL, "Unknown value " ZEND_LONG_FMT, what);
320320
break;
321321
}
322322

323-
RETURN_FALSE;
323+
return;
324324
}
325325
/* }}} */
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
--TEST--
2+
assert_options() - unknown assert option.
3+
4+
--FILE--
5+
<?php
6+
try {
7+
assert_options(1000);
8+
} catch (\Error $e) {
9+
echo $e->getMessage();
10+
}
11+
?>
12+
--EXPECT--
13+
Unknown value 1000

0 commit comments

Comments
 (0)