Skip to content

Commit 6d721b2

Browse files
committed
Use string literal equality helper function in xmlreader_get_method
1 parent da1a940 commit 6d721b2

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

ext/xmlreader/php_xmlreader.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,19 +181,12 @@ zval *xmlreader_write_property(zend_object *object, zend_string *name, zval *val
181181
/* {{{ */
182182
static zend_function *xmlreader_get_method(zend_object **obj, zend_string *name, const zval *key)
183183
{
184-
if (ZSTR_LEN(name) == sizeof("open") - 1
185-
&& (ZSTR_VAL(name)[0] == 'o' || ZSTR_VAL(name)[0] == 'O')
186-
&& (ZSTR_VAL(name)[1] == 'p' || ZSTR_VAL(name)[1] == 'P')
187-
&& (ZSTR_VAL(name)[2] == 'e' || ZSTR_VAL(name)[2] == 'E')
188-
&& (ZSTR_VAL(name)[3] == 'n' || ZSTR_VAL(name)[3] == 'N')) {
184+
if (zend_string_equals_literal_ci(name, "open")) {
189185
return (zend_function*)&xmlreader_open_fn;
190-
} else if (ZSTR_LEN(name) == sizeof("xml") - 1
191-
&& (ZSTR_VAL(name)[0] == 'x' || ZSTR_VAL(name)[0] == 'X')
192-
&& (ZSTR_VAL(name)[1] == 'm' || ZSTR_VAL(name)[1] == 'M')
193-
&& (ZSTR_VAL(name)[2] == 'l' || ZSTR_VAL(name)[2] == 'L')) {
186+
} else if (zend_string_equals_literal_ci(name, "xml")) {
194187
return (zend_function*)&xmlreader_xml_fn;
195188
}
196-
return zend_std_get_method(obj, name, key);;
189+
return zend_std_get_method(obj, name, key);
197190
}
198191
/* }}} */
199192

0 commit comments

Comments
 (0)