Remove exception in Randomizer::nextInt()

Same reasoning as in the previous commit applies, except that it won't throw on
a seriously biased user engine, as `range()` is not used.

Author: TimWolla

ext/random/randomizer.c

@@ -100,12 +100,11 @@ PHP_METHOD(Random_Randomizer, nextInt)
 	ZEND_PARSE_PARAMETERS_NONE();
 
 	result = randomizer->algo->generate(randomizer->status);
-	if (randomizer->status->last_generated_size > sizeof(zend_long)) {
-		zend_throw_exception(spl_ce_RuntimeException, "Generated value exceeds size of int", 0);
+	if (EG(exception)) {
 		RETURN_THROWS();
 	}
-	if (EG(exception)) {
-		zend_throw_exception(spl_ce_RuntimeException, "Random number generation failed", 0);
+	if (randomizer->status->last_generated_size > sizeof(zend_long)) {
+		zend_throw_exception(spl_ce_RuntimeException, "Generated value exceeds size of int", 0);
 		RETURN_THROWS();
 	}
 

ext/random/tests/03_randomizer/user_unsafe.phpt

@@ -15,7 +15,7 @@ final class EmptyStringEngine implements \Random\Engine {
 final class HeavilyBiasedEngine implements \Random\Engine {
     public function generate(): string
     {
-        return "\xff\xff\xff\xff\xff\xff\xff\xff";
+        return \str_repeat("\xff", PHP_INT_SIZE);
     }
 }
 
@@ -32,25 +32,33 @@ foreach ([
     } catch (Throwable $e) {
         echo $e, PHP_EOL;
     }
-    
+
     echo PHP_EOL, "-------", PHP_EOL, PHP_EOL;
-    
+
+    try {
+        var_dump((new Randomizer(new $engine()))->nextInt());
+    } catch (Throwable $e) {
+        echo $e, PHP_EOL;
+    }
+
+    echo PHP_EOL, "-------", PHP_EOL, PHP_EOL;
+
     try {
         var_dump(bin2hex((new Randomizer(new $engine()))->getBytes(1)));
     } catch (Throwable $e) {
         echo $e, PHP_EOL;
     }
-    
+
     echo PHP_EOL, "-------", PHP_EOL, PHP_EOL;
-    
+
     try {
         var_dump((new Randomizer(new $engine()))->shuffleArray(\range(1, 10)));
     } catch (Throwable $e) {
         echo $e, PHP_EOL;
     }
-    
+
     echo PHP_EOL, "-------", PHP_EOL, PHP_EOL;
-    
+
     try {
         var_dump((new Randomizer(new $engine()))->shuffleBytes('foobar'));
     } catch (Throwable $e) {
@@ -73,6 +81,13 @@ Stack trace:
 
 -------
 
+Error: A random engine must return a non-empty string in %s:%d
+Stack trace:
+#0 %s(%d): Random\Randomizer->nextInt()
+#1 {main}
+
+-------
+
 Error: A random engine must return a non-empty string in %s:%d
 Stack trace:
 #0 %s(%d): Random\Randomizer->getBytes(1)
@@ -108,6 +123,10 @@ Stack trace:
 
 -------
 
+int(%d)
+
+-------
+
 string(2) "ff"
 
 -------