Buffer size is now checked before memcmp

Author: SakiTakamachi

ext/pdo_sqlite/sqlite_driver.c

@@ -751,7 +751,7 @@ static char *make_filename_safe(const char *filename)
 		}
 		return estrdup(filename);
 	}
-	if (*filename && memcmp(filename, ":memory:", sizeof(":memory:"))) {
+	if (*filename && (sizeof(filename) != sizeof(":memory:") || memcmp(filename, ":memory:", sizeof(":memory:")) != 0)) {
 		char *fullpath = expand_filepath(filename, NULL);
 
 		if (!fullpath) {

ext/pdo_sqlite/tests/gh13991.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Fix GH-13984: Buffer size is now checked before memcmp
+--EXTENSIONS--
+pdo_sqlite
+--FILE--
+<?php
+$dbfile = 'z.db';
+$db = new PDO('sqlite:' . $dbfile, null, null, [PDO::ATTR_PERSISTENT => true]);
+echo 'done!';
+?>
+--CLEAN--
+<?php
+@unlink(getcwd() . '/z.db');
+?>
+--EXPECT--
+done!