ext/intl: introduce SpoofChecker::areBidiConfusable.

Adding a new more refined spoofchecker method in addition of the existing
SpoofChecker::areConfusable which takes in account the text direction
 left to right and right to left.
Adding UBIDI_LTR, UBIDI_RTL, UBIDI_MIXED and UBIDI_NEUTRAL.

Author: devnexen

ext/intl/spoofchecker/spoofchecker.stub.php

@@ -39,6 +39,16 @@ class Spoofchecker
     /** @cvalue USPOOF_HIDDEN_OVERLAY */
     public const int HIDDEN_OVERLAY = UNKNOWN;
 #endif
+#if U_ICU_VERSION_MAJOR_NUM >= 74
+    /** @cvalue UBIDI_LTR */
+    public const int UBIDI_LTR = UNKNOWN;
+    /** @cvalue UBIDI_RTL */
+    public const int UBIDI_RTL = UNKNOWN;
+    /** @cvalue UBIDI_MIXED */
+    public const int UBIDI_MIXED = UNKNOWN;
+    /** @cvalue UBIDI_NEUTRAL */
+    public const int UBIDI_NEUTRAL = UNKNOWN;
+#endif
 
     public function __construct() {}
 
@@ -64,4 +74,10 @@ public function setChecks(int $checks): void {}
     /** @tentative-return-type */
     public function setRestrictionLevel(int $level): void {}
 #endif
+#if U_ICU_VERSION_MAJOR_NUM >= 74
+    /**
+     * @param int $errorCode
+     */
+    public function areBidiConfusable(int $direction, string $string1, string $string2, &$errorCode = null): bool {}
+#endif
 }

ext/intl/spoofchecker/spoofchecker_arginfo.h

@@ -167,3 +167,42 @@ PHP_METHOD(Spoofchecker, setRestrictionLevel)
 }
 /* }}} */
 #endif
+
+#if U_ICU_VERSION_MAJOR_NUM >= 74
+PHP_METHOD(Spoofchecker, areBidiConfusable)
+{
+	int ret;
+	char *id1, *id2;
+	size_t length1, length2;
+	zend_long direction;
+	zval *error_code = NULL;
+	SPOOFCHECKER_METHOD_INIT_VARS;
+
+	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "lss|z", &direction, &id1, &length1,
+										 &id2, &length2, &error_code)) {
+		RETURN_THROWS();
+	}
+
+	SPOOFCHECKER_METHOD_FETCH_OBJECT;
+	if (direction != UBIDI_LTR && direction != UBIDI_RTL) {
+		zend_argument_value_error(1, "must be either SpoofChecker::UBIDI_LTR or SpoofChecker::UBIDI_RTL");
+		RETURN_THROWS();
+	}
+	if(length1 > INT32_MAX || length2 > INT32_MAX) {
+		SPOOFCHECKER_ERROR_CODE(co) = U_BUFFER_OVERFLOW_ERROR;
+	} else {
+		ret = uspoof_areBidiConfusableUTF8(co->uspoof, (UBiDiDirection)direction, id1, (int32_t)length1, id2, (int32_t)length2, SPOOFCHECKER_ERROR_CODE_P(co));
+	}
+	if (U_FAILURE(SPOOFCHECKER_ERROR_CODE(co))) {
+		php_error_docref(NULL, E_WARNING, "(%d) %s", SPOOFCHECKER_ERROR_CODE(co), u_errorName(SPOOFCHECKER_ERROR_CODE(co)));
+		RETURN_TRUE;
+	}
+
+	if (error_code) {
+		zval_ptr_dtor(error_code);
+		ZVAL_LONG(Z_REFVAL_P(error_code), ret);
+		Z_TRY_ADDREF_P(error_code);
+	}
+	RETVAL_BOOL(ret != 0);
+}
+#endif

ext/intl/spoofchecker/spoofchecker_main.c

@@ -0,0 +1,21 @@
+--TEST--
+spoofchecker checks if strings are confusable in a given direction.
+--EXTENSIONS--
+intl
+--SKIPIF--
+<?php if(!class_exists("Spoofchecker")) print 'skip'; ?>
+<?php if (version_compare(INTL_ICU_VERSION, '74.0') < 0)die('skip for ICU >= 74'); ?>
+--FILE--
+<?php
+$s = new SpoofChecker();
+try {
+    $s->areBidiConfusable(SpoofChecker::UBIDI_RTL + 1, "a", "a");
+} catch (ValueError $e) {
+    echo $e->getMessage() . PHP_EOL;
+}
+var_dump($s->areBidiConfusable(SpoofChecker::UBIDI_LTR, "\x73\x63", "sc"));
+var_dump($s->areBidiConfusable(SpoofChecker::UBIDI_RTL, "sc", "\x73\x63"));
+--EXPECT--
+Spoofchecker::areBidiConfusable(): Argument #1 ($direction) must be either SpoofChecker::UBIDI_LTR or SpoofChecker::UBIDI_RTL
+bool(true)
+bool(true)