Allow false as standalone type

Author: Girgias

Zend/tests/type_declarations/typed_properties_111.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Test typed properties allow false
+--FILE--
+<?php
+class Foo {
+    public false $value;
+}
+
+$foo = new Foo();
+?>
+===DONE===
+--EXPECT--
+===DONE===

Zend/tests/type_declarations/union_types/standalone_false.phpt

@@ -1,10 +1,11 @@
 --TEST--
-False cannot be used as a standalone type
+False can be used as a standalone type
 --FILE--
 <?php
 
 function test(): false {}
 
 ?>
---EXPECTF--
-Fatal error: false cannot be used as a standalone type in %s on line %d
+===DONE===
+--EXPECT--
+===DONE===

Zend/tests/type_declarations/union_types/standalone_false_implicit_nullability.phpt

@@ -1,10 +1,11 @@
 --TEST--
-False cannot be used as a standalone type even with implicit nullability
+False can be used as a standalone type even with implicit nullability
 --FILE--
 <?php
 
 function test(false $v = null) {}
 
 ?>
---EXPECTF--
-Fatal error: false cannot be used as a standalone type in %s on line %d
+===DONE===
+--EXPECT--
+===DONE===

Zend/tests/type_declarations/union_types/standalone_nullable_false.phpt

@@ -1,10 +1,11 @@
 --TEST--
-Nullable false cannot be used as a standalone type
+Nullable false can be used as a standalone type
 --FILE--
 <?php
 
 function test(): ?false {}
 
 ?>
---EXPECTF--
-Fatal error: false cannot be marked as nullable since false is not a standalone type in %s on line %d
+===DONE===
+--EXPECT--
+===DONE===

Zend/zend_compile.c

@@ -6345,14 +6345,6 @@ static zend_type zend_compile_typename(
 		zend_error_noreturn(E_COMPILE_ERROR, "null cannot be marked as nullable");
 	}
 
-	if ((type_mask & MAY_BE_FALSE) && !ZEND_TYPE_IS_COMPLEX(type) && !(type_mask & ~MAY_BE_FALSE)) {
-		if (is_marked_nullable) {
-			zend_error_noreturn(E_COMPILE_ERROR, "false cannot be marked as nullable since false is not a standalone type");
-		} else {
-			zend_error_noreturn(E_COMPILE_ERROR, "false cannot be used as a standalone type");
-		}
-	}
-
 	if (is_marked_nullable || force_allow_null) {
 		ZEND_TYPE_FULL_MASK(type) |= MAY_BE_NULL;
 		type_mask = ZEND_TYPE_PURE_MASK(type);

ext/reflection/tests/ReflectionType_possible_types.phpt

@@ -13,6 +13,7 @@ $functions = [
     function(): callable {},
     function(): iterable {},
     function(): null {},
+    function(): false {},
     function(): StdClass {}
 ];
 
@@ -32,4 +33,5 @@ string(5) "array"
 string(8) "callable"
 string(8) "iterable"
 string(4) "null"
+string(5) "false"
 string(8) "StdClass"

ext/reflection/tests/union_types.phpt

@@ -16,6 +16,7 @@ function dumpType(ReflectionUnionType $rt) {
 function test1(): X|Y|int|float|false|null { }
 function test2(): X|iterable|bool { }
 function test3(): null|false { }
+function test4(): ?false { }
 
 class Test {
     public X|Y|int $prop;
@@ -24,6 +25,7 @@ class Test {
 dumpType((new ReflectionFunction('test1'))->getReturnType());
 dumpType((new ReflectionFunction('test2'))->getReturnType());
 dumpType((new ReflectionFunction('test3'))->getReturnType());
+dumpType((new ReflectionFunction('test4'))->getReturnType());
 
 $rc = new ReflectionClass(Test::class);
 $rp = $rc->getProperty('prop');
@@ -78,6 +80,14 @@ Allows null: false
   String: bool
   Allows Null: false
 Type false|null:
+Allows null: true
+  Name: false
+  String: false
+  Allows Null: false
+  Name: null
+  String: null
+  Allows Null: true
+Type false|null:
 Allows null: true
   Name: false
   String: false