Fix implode() function signature

Author: kamil-tekiela

ext/standard/basic_functions.stub.php

@@ -2331,10 +2331,10 @@ function explode(string $separator, string $string, int $limit = PHP_INT_MAX): a
 /**
  * @compile-time-eval
  */
-function implode(string|array $separator, ?array $array = null): string {}
+function implode(string|array $separator, array $array = []): string {}
 
 /** @alias implode */
-function join(string|array $separator, ?array $array = null): string {}
+function join(string|array $separator, array $array = []): string {}
 
 /**
  * @compile-time-eval

ext/standard/basic_functions_arginfo.h

@@ -1030,7 +1030,7 @@ PHP_FUNCTION(implode)
 	ZEND_PARSE_PARAMETERS_START(1, 2)
 		Z_PARAM_ARRAY_HT_OR_STR(arg1_array, arg1_str)
 		Z_PARAM_OPTIONAL
-		Z_PARAM_ARRAY_HT_OR_NULL(pieces)
+		Z_PARAM_ARRAY_HT(pieces)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (pieces == NULL) {

ext/standard/string.c

@@ -267,11 +267,11 @@ string(%d) "Resource id #%d::Resource id #%d"
 
 *** Testing error conditions ***
 implode(): Argument #1 ($array) must be of type array, string given
-implode(): Argument #2 ($array) must be of type ?array, int given
-implode(): Argument #1 ($array) must be of type array, string given
+implode(): Argument #2 ($array) must be of type array, int given
+implode(): Argument #2 ($array) must be of type array, null given
 string(0) ""
-implode(): Argument #2 ($array) must be of type ?array, string given
+implode(): Argument #2 ($array) must be of type array, string given
 
 Deprecated: implode(): Passing null to parameter #1 ($separator) of type array|string is deprecated in %s on line %d
-implode(): Argument #2 ($array) must be of type ?array, string given
+implode(): Argument #2 ($array) must be of type array, string given
 Done

ext/standard/tests/strings/implode1.phpt

@@ -102,49 +102,49 @@ echo "Done\n";
 
 --- Testing join() by supplying different values for 'pieces' argument ---
 -- Iteration 1 --
-join(): Argument #2 ($array) must be of type ?array, int given
+join(): Argument #2 ($array) must be of type array, int given
 -- Iteration 2 --
-join(): Argument #2 ($array) must be of type ?array, int given
+join(): Argument #2 ($array) must be of type array, int given
 -- Iteration 3 --
-join(): Argument #2 ($array) must be of type ?array, int given
+join(): Argument #2 ($array) must be of type array, int given
 -- Iteration 4 --
-join(): Argument #2 ($array) must be of type ?array, int given
+join(): Argument #2 ($array) must be of type array, int given
 -- Iteration 5 --
-join(): Argument #2 ($array) must be of type ?array, float given
+join(): Argument #2 ($array) must be of type array, float given
 -- Iteration 6 --
-join(): Argument #2 ($array) must be of type ?array, float given
+join(): Argument #2 ($array) must be of type array, float given
 -- Iteration 7 --
-join(): Argument #2 ($array) must be of type ?array, float given
+join(): Argument #2 ($array) must be of type array, float given
 -- Iteration 8 --
-join(): Argument #2 ($array) must be of type ?array, float given
+join(): Argument #2 ($array) must be of type array, float given
 -- Iteration 9 --
-join(): Argument #2 ($array) must be of type ?array, float given
+join(): Argument #2 ($array) must be of type array, float given
 -- Iteration 10 --
-join(): Argument #2 ($array) must be of type ?array, true given
+join(): Argument #2 ($array) must be of type array, true given
 -- Iteration 11 --
-join(): Argument #2 ($array) must be of type ?array, false given
+join(): Argument #2 ($array) must be of type array, false given
 -- Iteration 12 --
-join(): Argument #2 ($array) must be of type ?array, true given
+join(): Argument #2 ($array) must be of type array, true given
 -- Iteration 13 --
-join(): Argument #2 ($array) must be of type ?array, false given
+join(): Argument #2 ($array) must be of type array, false given
 -- Iteration 14 --
-join(): Argument #2 ($array) must be of type ?array, string given
+join(): Argument #2 ($array) must be of type array, string given
 -- Iteration 15 --
-join(): Argument #2 ($array) must be of type ?array, string given
+join(): Argument #2 ($array) must be of type array, string given
 -- Iteration 16 --
-join(): Argument #2 ($array) must be of type ?array, test given
+join(): Argument #2 ($array) must be of type array, test given
 -- Iteration 17 --
-join(): Argument #2 ($array) must be of type ?array, string given
+join(): Argument #2 ($array) must be of type array, string given
 -- Iteration 18 --
-join(): Argument #2 ($array) must be of type ?array, string given
+join(): Argument #2 ($array) must be of type array, string given
 -- Iteration 19 --
-join(): Argument #1 ($array) must be of type array, string given
+join(): Argument #2 ($array) must be of type array, null given
 -- Iteration 20 --
-join(): Argument #1 ($array) must be of type array, string given
+join(): Argument #2 ($array) must be of type array, null given
 -- Iteration 21 --
-join(): Argument #2 ($array) must be of type ?array, resource given
+join(): Argument #2 ($array) must be of type array, resource given
 -- Iteration 22 --
-join(): Argument #1 ($array) must be of type array, string given
+join(): Argument #2 ($array) must be of type array, null given
 -- Iteration 23 --
-join(): Argument #1 ($array) must be of type array, string given
+join(): Argument #2 ($array) must be of type array, null given
 Done