Skip to content

Commit 811f6dd

Browse files
committed
Review parameter names in ext/enchant
Closes GH-6258
1 parent 6b00196 commit 811f6dd

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

ext/enchant/enchant.stub.php

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ function enchant_broker_free(EnchantBroker $broker): bool {}
1818
function enchant_broker_get_error(EnchantBroker $broker): string|false {}
1919

2020
/** @deprecated */
21-
function enchant_broker_set_dict_path(EnchantBroker $broker, int $name, string $value): bool {}
21+
function enchant_broker_set_dict_path(EnchantBroker $broker, int $type, string $path): bool {}
2222

2323
/** @deprecated */
24-
function enchant_broker_get_dict_path(EnchantBroker $broker, int $name): string|false {}
24+
function enchant_broker_get_dict_path(EnchantBroker $broker, int $type): string|false {}
2525

2626
function enchant_broker_list_dicts(EnchantBroker $broker): array {}
2727

@@ -30,7 +30,7 @@ function enchant_broker_request_dict(EnchantBroker $broker, string $tag): Enchan
3030
function enchant_broker_request_pwl_dict(EnchantBroker $broker, string $filename): EnchantDictionary|false {}
3131

3232
/** @deprecated */
33-
function enchant_broker_free_dict(EnchantDictionary $dict): bool {}
33+
function enchant_broker_free_dict(EnchantDictionary $dictionary): bool {}
3434

3535
function enchant_broker_dict_exists(EnchantBroker $broker, string $tag): bool {}
3636

@@ -39,32 +39,32 @@ function enchant_broker_set_ordering(EnchantBroker $broker, string $tag, string
3939
function enchant_broker_describe(EnchantBroker $broker): array {}
4040

4141
/** @param array $suggestions */
42-
function enchant_dict_quick_check(EnchantDictionary $dict, string $word, &$suggestions = null): bool {}
42+
function enchant_dict_quick_check(EnchantDictionary $dictionary, string $word, &$suggestions = null): bool {}
4343

44-
function enchant_dict_check(EnchantDictionary $dict, string $word): bool {}
44+
function enchant_dict_check(EnchantDictionary $dictionary, string $word): bool {}
4545

46-
function enchant_dict_suggest(EnchantDictionary $dict, string $word): array {}
46+
function enchant_dict_suggest(EnchantDictionary $dictionary, string $word): array {}
4747

48-
function enchant_dict_add(EnchantDictionary $dict, string $word): void {}
48+
function enchant_dict_add(EnchantDictionary $dictionary, string $word): void {}
4949

5050
/**
5151
* @alias enchant_dict_add
5252
* @deprecated
5353
*/
54-
function enchant_dict_add_to_personal(EnchantDictionary $dict, string $word): void {}
54+
function enchant_dict_add_to_personal(EnchantDictionary $dictionary, string $word): void {}
5555

56-
function enchant_dict_add_to_session(EnchantDictionary $dict, string $word): void {}
56+
function enchant_dict_add_to_session(EnchantDictionary $dictionary, string $word): void {}
5757

58-
function enchant_dict_is_added(EnchantDictionary $dict, string $word): bool {}
58+
function enchant_dict_is_added(EnchantDictionary $dictionary, string $word): bool {}
5959

6060
/**
6161
* @alias enchant_dict_is_added
6262
* @deprecated
6363
*/
64-
function enchant_dict_is_in_session(EnchantDictionary $dict, string $word): bool {}
64+
function enchant_dict_is_in_session(EnchantDictionary $dictionary, string $word): bool {}
6565

66-
function enchant_dict_store_replacement(EnchantDictionary $dict, string $mis, string $cor): void {}
66+
function enchant_dict_store_replacement(EnchantDictionary $dictionary, string $misspelled, string $correct): void {}
6767

68-
function enchant_dict_get_error(EnchantDictionary $dict): string|false {}
68+
function enchant_dict_get_error(EnchantDictionary $dictionary): string|false {}
6969

70-
function enchant_dict_describe(EnchantDictionary $dict): array {}
70+
function enchant_dict_describe(EnchantDictionary $dictionary): array {}

ext/enchant/enchant_arginfo.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 22c47f0b30f6952a42546c403fbd2e92836661fa */
2+
* Stub hash: 31f7c4cd39e58d6474b90acd65f4b7bda7a6ddf3 */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_enchant_broker_init, 0, 0, EnchantBroker, MAY_BE_FALSE)
55
ZEND_END_ARG_INFO()
@@ -14,13 +14,13 @@ ZEND_END_ARG_INFO()
1414

1515
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_broker_set_dict_path, 0, 3, _IS_BOOL, 0)
1616
ZEND_ARG_OBJ_INFO(0, broker, EnchantBroker, 0)
17-
ZEND_ARG_TYPE_INFO(0, name, IS_LONG, 0)
18-
ZEND_ARG_TYPE_INFO(0, value, IS_STRING, 0)
17+
ZEND_ARG_TYPE_INFO(0, type, IS_LONG, 0)
18+
ZEND_ARG_TYPE_INFO(0, path, IS_STRING, 0)
1919
ZEND_END_ARG_INFO()
2020

2121
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_enchant_broker_get_dict_path, 0, 2, MAY_BE_STRING|MAY_BE_FALSE)
2222
ZEND_ARG_OBJ_INFO(0, broker, EnchantBroker, 0)
23-
ZEND_ARG_TYPE_INFO(0, name, IS_LONG, 0)
23+
ZEND_ARG_TYPE_INFO(0, type, IS_LONG, 0)
2424
ZEND_END_ARG_INFO()
2525

2626
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_broker_list_dicts, 0, 1, IS_ARRAY, 0)
@@ -38,7 +38,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_enchant_broker_request_pwl_d
3838
ZEND_END_ARG_INFO()
3939

4040
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_broker_free_dict, 0, 1, _IS_BOOL, 0)
41-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
41+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
4242
ZEND_END_ARG_INFO()
4343

4444
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_broker_dict_exists, 0, 2, _IS_BOOL, 0)
@@ -55,23 +55,23 @@ ZEND_END_ARG_INFO()
5555
#define arginfo_enchant_broker_describe arginfo_enchant_broker_list_dicts
5656

5757
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_dict_quick_check, 0, 2, _IS_BOOL, 0)
58-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
58+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
5959
ZEND_ARG_TYPE_INFO(0, word, IS_STRING, 0)
6060
ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, suggestions, "null")
6161
ZEND_END_ARG_INFO()
6262

6363
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_dict_check, 0, 2, _IS_BOOL, 0)
64-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
64+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
6565
ZEND_ARG_TYPE_INFO(0, word, IS_STRING, 0)
6666
ZEND_END_ARG_INFO()
6767

6868
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_dict_suggest, 0, 2, IS_ARRAY, 0)
69-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
69+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
7070
ZEND_ARG_TYPE_INFO(0, word, IS_STRING, 0)
7171
ZEND_END_ARG_INFO()
7272

7373
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_dict_add, 0, 2, IS_VOID, 0)
74-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
74+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
7575
ZEND_ARG_TYPE_INFO(0, word, IS_STRING, 0)
7676
ZEND_END_ARG_INFO()
7777

@@ -84,17 +84,17 @@ ZEND_END_ARG_INFO()
8484
#define arginfo_enchant_dict_is_in_session arginfo_enchant_dict_check
8585

8686
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_dict_store_replacement, 0, 3, IS_VOID, 0)
87-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
88-
ZEND_ARG_TYPE_INFO(0, mis, IS_STRING, 0)
89-
ZEND_ARG_TYPE_INFO(0, cor, IS_STRING, 0)
87+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
88+
ZEND_ARG_TYPE_INFO(0, misspelled, IS_STRING, 0)
89+
ZEND_ARG_TYPE_INFO(0, correct, IS_STRING, 0)
9090
ZEND_END_ARG_INFO()
9191

9292
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_enchant_dict_get_error, 0, 1, MAY_BE_STRING|MAY_BE_FALSE)
93-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
93+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
9494
ZEND_END_ARG_INFO()
9595

9696
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_enchant_dict_describe, 0, 1, IS_ARRAY, 0)
97-
ZEND_ARG_OBJ_INFO(0, dict, EnchantDictionary, 0)
97+
ZEND_ARG_OBJ_INFO(0, dictionary, EnchantDictionary, 0)
9898
ZEND_END_ARG_INFO()
9999

100100

0 commit comments

Comments
 (0)