Avoid memory leak bug with msodbcsql

Author: SakiTakamachi

ext/odbc/tests/odbc_connect_001.phpt

@@ -16,35 +16,40 @@ include 'skipif.inc';
 include 'config.inc';
 $dsn = str_replace(";uid={$user};pwd={$pass}", '', $dsn);
 
+/*
+ * A bug in msodbcsql causes a memory leak when reconnecting after closing.
+ * Therefore, avoid closing it.
+ */
+
 echo "dsn without credentials / correct user / correct password\n";
 $conn = odbc_connect($dsn, $user, $pass);
 echo $conn ? "Connected.\n\n" : "";
-if ($conn) odbc_close($conn);
+// if ($conn) odbc_close($conn);
 
 echo "dsn with correct user / incorrect user / correct password\n";
 $conn = odbc_connect("{$dsn};uid={$user}", 'hoge', $pass);
 echo $conn ? "Connected.\n\n" : "";
-if ($conn) odbc_close($conn);
+// if ($conn) odbc_close($conn);
 
 echo "dsn with correct password / correct user / incorrect password\n";
 $conn = odbc_connect("{$dsn};PWD={$pass}", $user, 'fuga');
 echo $conn ? "Connected.\n\n" : "";
-if ($conn) odbc_close($conn);
+// if ($conn) odbc_close($conn);
 
 echo "dsn with correct credentials / incorrect user / incorrect password\n";
 $conn = odbc_connect("{$dsn};Uid={$user};pwD={$pass}", 'hoge', 'fuga');
 echo $conn ? "Connected.\n\n" : "";
-if ($conn) odbc_close($conn);
+// if ($conn) odbc_close($conn);
 
 echo "dsn with correct credentials / null user / null password\n";
 $conn = odbc_connect("{$dsn};Uid={$user};pwD={$pass}", null, null);
 echo $conn ? "Connected.\n\n" : "";
-if ($conn) odbc_close($conn);
+// if ($conn) odbc_close($conn);
 
 echo "dsn with correct credentials / not set user / not set password\n";
 $conn = odbc_connect("{$dsn};Uid={$user};pwD={$pass}");
 echo $conn ? "Connected.\n" : "";
-if ($conn) odbc_close($conn);
+// if ($conn) odbc_close($conn);
 ?>
 --EXPECT--
 dsn without credentials / correct user / correct password

ext/pdo_odbc/tests/basic_connection.phpt

@@ -19,11 +19,16 @@ $password = getenv('PDO_ODBC_TEST_PASS');
 
 $dsn = str_replace(";uid={$user};pwd={$password}", '', $dsnWithCredentials);
 
+/*
+ * A bug in msodbcsql causes a memory leak when reconnecting after closing.
+ * Therefore, avoid closing it.
+ */
+
 echo "dsn without credentials / correct user / correct password\n";
 try {
     $db = new PDO($dsn, $user, $password, [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
     echo "Connected.\n\n";
-    $db = null;
+    // $db = null;
 } catch (PDOException $e) {
     echo $e->getMessage()."\n";
 }
@@ -32,7 +37,7 @@ echo "dsn with credentials / no user / no password\n";
 try {
     $db = new PDO("{$dsn};uid={$user};pwd={$password}", null, null, [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
     echo "Connected.\n\n";
-    $db = null;
+    // $db = null;
 } catch (PDOException $e) {
     echo $e->getMessage()."\n";
 }
@@ -41,7 +46,7 @@ echo "dsn with correct user / incorrect user / correct password\n";
 try {
     $db = new PDO("{$dsn};UID={$user}", 'hoge', $password, [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
     echo "Connected.\n\n";
-    $db = null;
+    // $db = null;
 } catch (PDOException $e) {
     echo $e->getMessage()."\n";
 }
@@ -50,7 +55,7 @@ echo "dsn with correct password / correct user / incorrect password\n";
 try {
     $db = new PDO("{$dsn};PWD={$password}", $user, 'fuga', [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
     echo "Connected.\n\n";
-    $db = null;
+    // $db = null;
 } catch (PDOException $e) {
     echo $e->getMessage()."\n";
 }
@@ -59,7 +64,7 @@ echo "dsn with correct credentials / incorrect user / incorrect password\n";
 try {
     $db = new PDO("{$dsn};Uid={$user};Pwd={$password}", 'hoge', 'fuga', [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
     echo "Connected.\n";
-    $db = null;
+    // $db = null;
 } catch (PDOException $e) {
     echo $e->getMessage()."\n";
 }