Skip to content

Commit 816aea7

Browse files
authored
Autotools: Mark always-shared extensions with ext_shared variable (#15739)
This makes future config.m4 files changes simpler in case of adding additional checks, macro calls etc. Or if these extensions configuration would change at some point.
1 parent 035b0c5 commit 816aea7

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

ext/dl_test/config.m4

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@ PHP_ARG_ENABLE([dl-test],
44
[Enable dl_test extension])])
55

66
if test "$PHP_DL_TEST" != "no"; then
7+
dnl Always build as shared extension.
8+
ext_shared=yes
9+
710
PHP_NEW_EXTENSION([dl_test],
811
[dl_test.c],
9-
[shared],,
12+
[$ext_shared],,
1013
[-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1])
1114
fi

ext/opcache/config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ PHP_ARG_WITH([capstone],
2626
[no])
2727

2828
if test "$PHP_OPCACHE" != "no"; then
29-
dnl Always build as shared extension
29+
dnl Always build as shared extension.
3030
ext_shared=yes
3131

3232
AS_VAR_IF([PHP_HUGE_CODE_PAGES], [yes],
@@ -339,7 +339,7 @@ int main(void) {
339339
ZendAccelerator.c
340340
$ZEND_JIT_SRC
341341
]),
342-
[shared],,
342+
[$ext_shared],,
343343
[-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 $JIT_CFLAGS],,
344344
[yes])
345345

0 commit comments

Comments
 (0)