Fix oci8.old_oci_close_semantics deprecation is always displayed

kocsismate · kocsismate · commit 87c181a0b081 · 2021-07-22T16:21:46.000+02:00
diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
@@ -132,7 +132,7 @@ static PHP_INI_MH(OnUpdateOldCloseSemantics)
 	bool *p = (bool *) ZEND_INI_GET_ADDR();
 	*p = zend_ini_parse_bool(new_value);
 
-	if (p) {
+	if (*p) {
 		zend_error(E_DEPRECATED, "Directive oci8.old_oci_close_semantics is deprecated");
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ static PHP_INI_MH(OnUpdateOldCloseSemantics)`
`132`	`132`	`bool p = (bool ) ZEND_INI_GET_ADDR();`
`133`	`133`	`*p = zend_ini_parse_bool(new_value);`
`134`	`134`
`135`		`- if (p) {`
	`135`	`+ if (*p) {`
`136`	`136`	`zend_error(E_DEPRECATED, "Directive oci8.old_oci_close_semantics is deprecated");`
`137`	`137`	`}`
`138`	`138`