Buffer size is now checked before memcmp

SakiTakamachi · SakiTakamachi · commit 94cfc0dcca68 · 2024-04-18T00:44:39.000+09:00
diff --git a/ext/pdo_sqlite/sqlite_driver.c b/ext/pdo_sqlite/sqlite_driver.c
@@ -751,7 +751,7 @@ static char *make_filename_safe(const char *filename)
 		}
 		return estrdup(filename);
 	}
-	if (*filename && memcmp(filename, ":memory:", sizeof(":memory:"))) {
+	if (*filename && (sizeof(filename) != sizeof(":memory:") || memcmp(filename, ":memory:", sizeof(":memory:")) != 0)) {
 		char *fullpath = expand_filepath(filename, NULL);
 
 		if (!fullpath) {

Original file line number	Diff line number	Diff line change
`@@ -751,7 +751,7 @@ static char make_filename_safe(const char filename)`
`751`	`751`	`}`
`752`	`752`	`return estrdup(filename);`
`753`	`753`	`}`
`754`		`- if (*filename && memcmp(filename, ":memory:", sizeof(":memory:"))) {`
	`754`	`+ if (*filename && (sizeof(filename) != sizeof(":memory:") \|\| memcmp(filename, ":memory:", sizeof(":memory:")) != 0)) {`
`755`	`755`	`char *fullpath = expand_filepath(filename, NULL);`
`756`	`756`
`757`	`757`	`if (!fullpath) {`